[CLOUD-3941] - Logger configurations in OCP #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spolti could you please take a look? thanks! |
|
lgtm, @luck3y please take a look when you have time. |
jfdenise
reviewed
Jul 16, 2021
| elif [ "${configureMode}" = "cli" ]; then | ||
| configureByCLI | ||
| configurePatternFormatterByCLI |
There was a problem hiding this comment.
This call will not have any effect. the generated CLI operations needs to be added to the CLI script file.
Should be: configurePatternFormatterByCLI >> ${CLI_SCRIPT_FILE}
See: https://issues.redhat.com/browse/CLOUD-3941 Signed-off-by: Mauricio Magnani <msmagnanijr@gmail.com>
|
@msmagnanijr Is there a version of this in master already? |
@luck3y actually not yet. |
|
@msmagnanijr We'd generally need master first then cherry-picked to the branch. Otherwise this change will just get lost in the next version. |
|
We'll take another approach. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://issues.redhat.com/browse/CLOUD-3941
Signed-off-by: Mauricio Magnani msmagnanijr@gmail.com