[WFCORE-1015] init jboss cli jconsole plugin with the remote mbean co… #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection that is established, so it can load
| @@ -119,6 +119,7 @@ private void connect() throws Exception { | |||
| if (mbeanServerConn instanceof RemotingMBeanServerConnection) { | |||
| final CommandContext cmdCtx = CommandContextFactory.getInstance().newCommandContext(); | |||
| isConnected = connectUsingRemoting(cmdCtx, (RemotingMBeanServerConnection)mbeanServerConn); | |||
| init(cmdCtx); | |||
There was a problem hiding this comment.
It doesn't seem right to ignore the result of L121 here. The init(cmdCtx) call will end up setting isConnected = true, but if L121 returns 'false' the plugin isn't actually connected.
I haven't looked carefully, but it seems like it should be more like this:
if (connectUsingRemoting(cmdCtx, (RemotingMBeanServerConnection)mbeanServerConn)) {
init(cmdCtx);
} else {
doSomethingButBrianIsntSureWHAT();
}
The doSomethingButBrianIsntSureWHAT is probably display some sort of error dialog. This would mean the user has a RemotingMBeanServerConnection to something but a management channel can't be opened on it. This seems highly unlikely and the right thing to do to recover is unclear, so just failing seems reasonable.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nnection that is established, so it can load
jira: https://issues.jboss.org/browse/WFCORE-1015