Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-1112 use logger.debugf instead of manual string concatenation #1219

Merged
merged 1 commit into from
Mar 18, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ private void addAllDependenciesAndPermissions(final ModuleSpecification moduleSp
private ServiceName createModuleService(final DeploymentPhaseContext phaseContext, final DeploymentUnit deploymentUnit,
final List<ResourceRoot> resourceRoots, final ModuleSpecification moduleSpecification,
final ModuleIdentifier moduleIdentifier) throws DeploymentUnitProcessingException {
logger.debug("Creating module: " + moduleIdentifier);
logger.debugf("Creating module: %s", moduleIdentifier);
final ModuleSpec.Builder specBuilder = ModuleSpec.build(moduleIdentifier);
for (final DependencySpec dep : moduleSpecification.getModuleSystemDependencies()) {
specBuilder.addDependency(dep);
Expand All @@ -218,12 +218,12 @@ private ServiceName createModuleService(final DeploymentPhaseContext phaseContex

// add additional resource loaders first
for (final ResourceLoaderSpec resourceLoaderSpec : moduleSpecification.getResourceLoaders()) {
logger.debug("Adding resource loader " + resourceLoaderSpec + " to module " + moduleIdentifier);
logger.debugf("Adding resource loader %s to module %s", resourceLoaderSpec, moduleIdentifier);
specBuilder.addResourceRoot(resourceLoaderSpec);
}

for (final ResourceRoot resourceRoot : resourceRoots) {
logger.debug("Adding resource " + resourceRoot.getRoot() + " to module " + moduleIdentifier);
logger.debugf("Adding resource %s to module %s", resourceRoot.getRoot(), moduleIdentifier);
addResourceRoot(specBuilder, resourceRoot, permFactories);
}

Expand Down Expand Up @@ -325,7 +325,7 @@ private void createDependencies(final ModuleSpec.Builder specBuilder, final List
final DependencySpec depSpec = DependencySpec.createModuleDependencySpec(importFilter, exportFilter, dependency
.getModuleLoader(), dependency.getIdentifier(), dependency.isOptional());
specBuilder.addDependency(depSpec);
logger.debug("Adding dependency " + dependency + " to module " + specBuilder.getIdentifier());
logger.debugf("Adding dependency %s to module %s", dependency, specBuilder.getIdentifier());
}
}
}
Expand Down