New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-1029] Stop using InetSocketAddress as map key in UnnamedBindingRegistry #1242
Conversation
8f2482d
to
64d47a1
Compare
static final class UnnamedRegistryImpl implements UnnamedBindingRegistry { | ||
private final Map<InetSocketAddress, ManagedBinding> bindings = new ConcurrentHashMap<InetSocketAddress, ManagedBinding>(); | ||
private static final class UnnamedRegistryImpl implements UnnamedBindingRegistry { | ||
private final Map<WrapperBinding, Void> bindings = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a Set would be better, but we either can't use a null
value or we need to change the map type. Per the ConcurrentHashMap JavaDoc
Like Hashtable but unlike HashMap, this class does not allow null to be used as a key or value.
64d47a1
to
0543592
Compare
0543592
to
0f04838
Compare
Core - Full Integration Build 2361 outcome was FAILURE using a merge of 0f04838 Failed tests
|
0f04838
to
2d08375
Compare
Windows Build 2762 outcome was FAILURE using a merge of 2d08375 Failed tests
|
Core - Full Integration Build 2371 outcome was FAILURE using a merge of 2d08375 |
retest this please |
2d08375
to
91a1e03
Compare
Core - Full Integration Build 2667 outcome was FAILURE using a merge of 91a1e03 |
Full integration - Windows Build 1093 outcome was FAILURE using a merge of 91a1e03 |
retest this please |
…ngRegistry so it won't matter if sockets are bound at the moment of registering/unregistering
[WFCORE-1029] Stop using InetSocketAddress as map key in UnnamedBindingRegistry
This builds on #1239 but adds an additional commit for https://issues.jboss.org/browse/WFCORE-1029.
I'm using separate PRs for these because the different related issues have, IMO, different degrees of acceptability for inclusion in EAP 7. I believe including the WFCORE-1029 fix is the correct ultimate solution, but having added bake time makes sense to me.