New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-1232] adjust patching testsuite after WFCORE-838 #1287
Conversation
import static org.jboss.as.test.patching.PatchingTestUtil.PRODUCT; | ||
import static org.jboss.as.test.patching.PatchingTestUtil.createPatchXMLFile; | ||
import static org.jboss.as.test.patching.PatchingTestUtil.createZippedPatchFile; | ||
import static org.jboss.as.test.patching.PatchingTestUtil.randomString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous import ordering was correct per WildFly standards. Please adjust your IDE to either not reorder or to use the standard order. Thanks.
@aloubyansky Please approve when you get time. The CLIWrapper part seems fine, but I don't know what you think about the patching test part. |
The new tests look valid to me. Perhaps, I'm missing something here but the question I have is why a re-write instead of a separate test for the new feature? We are still going to support bundles, so what's the reason to reduce the test coverage? |
Okay then, I will copy this into a new test case and leave the old one there. |
82c89f1
to
a72d8a6
Compare
retest this please |
I created both jiras, reverted the old test case and fixed imports. |
Core - Full Integration Build 2449 outcome was FAILURE using a merge of a72d8a6 Failed tests
|
[WFCORE-1232] adjust patching testsuite after WFCORE-838
Test merged patches (introduced by https://issues.jboss.org/browse/WFCORE-838) in addition to the old patch-bundles. Also made CLIWrapper implement AutoCloseable to shorten some pieces of code.
https://issues.jboss.org/browse/WFCORE-1232