[WFCORE-1028]: Poor handling of invalid roles. #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsavoie
force-pushed
the
WFCORE-1028
branch
from
03282fd
to
1f72fbc
Compare
| @Override | ||
| public void handleResult(OperationContext.ResultAction resultAction, OperationContext context, ModelNode operation) { | ||
| if(fakeOperationResponse != null && fakeOperationResponse.hasDefined(FAILURE_DESCRIPTION)) { | ||
| context.setRollbackOnly(); |
There was a problem hiding this comment.
Is this necessary? I don't think it should be needed, since whatever step populated fakeOperationResponse has already reported a problem. So I think it's out-of-scope for this result handler to be manipulating the OC's resultAction.
Getting the authorization error passed to the handler so it can get back cleanly.
bstansberry
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the authorization error passed to the handler so it can get back cleanly.
Jira: https://issues.jboss.org/browse/WFCORE-1028