[WFCORE-1239] Embedded API is confusing re: process types #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Core - Full Integration Build 2458 outcome was FAILURE using a merge of 44dc591 Failed tests |
Introduce a new factory class EmbeddedProcessFactory to replace the now deprecated EmbeddedServerFactory. Introduce a new EmbeddedManagedProcess interface as the super-interface for the existing StandaloneServer and HostController interfaces, thus unifying their APIs Subclass ServerStartException with EmbeddedProcessStartException and then deprecate the superclass. Move offline CLI to the above. Misc minor cleanups.
bstansberry
force-pushed
the
embed-api
branch
from
44dc591
to
4fc9ebd
Compare
n1hility
added a commit
that referenced
this pull request
Dec 21, 2015
[WFCORE-1239] Embedded API is confusing re: process types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about cleaning up the use of the term 'server' in the embedded API in places where the relevant thing may be either a standalone server or a host controller.
I introduce a new factory class EmbeddedProcessFactory to replace the now deprecated EmbeddedServerFactory. I introduce a new EmbeddedManagedProcess interface as the super-interface for the existing StandaloneServer and HostController interfaces, thus unifying their APIs. I subclass ServerStartException with EmbeddedProcessStartException and then deprecate the superclass.
There were two minor breaking changes needed versus core 2.0.0:
The HostController interface has an odd "public HostController getHostController()" method that logically would only return 'this'. I could keep this but it's not needed and I'd rather get rid of it now before someone external starts using it.
The HostController interface's start() method does not throw a checked exception, while the equivalent start() on StandaloneServer does. To do anything coherent I need to unify the exception handling. HostController is extremely unlikely to be used outside wf core, while StandaloneServer is used, and removing a checked exception from StandaloneServer would be a breaking change or any user that catches it, so instead I will add the exception to HostController.start().
I think both of these are ok as I don't envision anyone other than the CLI using the HostController interface at this point.