-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-1306] SlaveReconnectTestCase fails on slow systems #1393
Conversation
Core - Full Integration Build 2651 outcome was FAILURE using a merge of f01ef9c Failed tests
|
Retest this please |
@@ -148,6 +151,14 @@ private void testReconnect(ReconnectTestScenario[] scenarios) throws Exception { | |||
slaveReconnected = checkSlaveReconnected(masterClient); | |||
} while (!slaveReconnected && System.currentTimeMillis() < end); | |||
|
|||
//Wait for master servers to come up | |||
end = System.currentTimeMillis() + 20 * ADJUSTED_SECOND; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 sounds too low.
If the test is going to fail, waiting a long time for it to happen is no big deal. But a false failure because of a short timeout is bad.
f01ef9c
to
af917cb
Compare
Timeout increased to adjusted 60s. |
[WFCORE-1306] SlaveReconnectTestCase fails on slow systems
JIRA: https://issues.jboss.org/browse/WFCORE-1306