[WFCORE-1340] Provide domain-wide exclusion data for use by DC in managing mixed domains #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
kabir
added
ready-for-merge
n1hility
added a commit
that referenced
this pull request
Feb 5, 2016
[WFCORE-1340] Provide domain-wide exclusion data for use by DC in managing mixed domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the description of https://issues.jboss.org/browse/WFCORE-1340 for a detailed specification of what this PR is all about. The recent comments on https://issues.jboss.org/browse/JBEAP-2888 are useful background.
I will shortly send up a separate PR for full that includes testing of this functionality in full's testsuite/mixed-domain suite. (Edit: that PR is up -- wildfly/wildfly#8649)
The first two commits in this PR fix problems uncovered by that testing. They are not directly related to WFCORE-1340, although they do impact the mixed-domain use case in general. They are included here because not fixing them prevents the kind of robust testing that I think this work requires.
http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=89310&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments is a custom test of the core and full PRs together. It passed. http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=89372&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments is a second run. It passed too.
And another one on Windows: http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=89401&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows