Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-1362 Add --connection-properties to datasource add command #1412

Merged
merged 1 commit into from Mar 18, 2016

Conversation

aloubyansky
Copy link
Contributor

Thanks,
Alexey

@aloubyansky
Copy link
Contributor Author

I am looking into the failure.

@bstansberry
Copy link
Contributor

retest this please

@bstansberry
Copy link
Contributor

Looks good. I'd like it if the server side datasource add handler could just accept the properties as a param and do this server side, but I don't know when we'll get around to that, so this is good.

Really, I'd like what I describe ^^^ to be something the kernel can do automagically; i.e. look for add op params that look like child resources and convert those into added steps to add the child(ren). Part of doing that would mean the CLI's operation validation logic would need to understand that too and not reject the op because of the "extra" params. Or perhaps the "add" op description generator can automagically add child types as valid params.

Anyway, just FYI about some thoughts.

@aloubyansky
Copy link
Contributor Author

We discussed the issue for the XA properties back in the days. I also argued it had to be done on the server side. If one day the operation is able to accept more parameters, it will have to be clearly enough reflected in the description, so the operation request validation will remain straightforward.

@bstansberry bstansberry added ready-for-merge This PR is ready to be merged and fulfills all requirements 3.x labels Feb 17, 2016
bstansberry added a commit that referenced this pull request Mar 18, 2016
WFCORE-1362 Add --connection-properties to datasource add command
@bstansberry bstansberry merged commit 7eab818 into wildfly:master Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
2 participants