[WFCORE-1430]: Deployment scanner logs ERROR when server is shutting down. #1455
+22
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down. When server is shutting down we are setting the scanEnabled to false and ignore errors on ScanContext creation since the scan doesn't make any sense.
bstansberry
added
ready-for-merge
|
Looks good. This isn't related to this PR but I noticed it when reviewing it, so something to look into some day: the ScanResult class has two fields 'requireUndeploy' and 'tasks' that are unused. So if they aren't going to be used someday, the whole ScanResult class really amounts to the 'scheduleRescan' boolean. |
bstansberry
added a commit
that referenced
this pull request
Mar 18, 2016
[WFCORE-1430]: Deployment scanner logs ERROR when server is shutting down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When server is shutting down we are setting the scanEnabled to false and ignore errors on ScanContext creation since the scan doesn't make any sense.