Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-1450] Use a copy constructor instead of a subclass #1472

Merged
merged 2 commits into from Mar 30, 2016

Conversation

bstansberry
Copy link
Contributor

Also includes a commit converting some classes to nested classes of the main class in the file.

@wildfly-ci
Copy link

Core - Full Integration Build 2885 outcome was FAILURE using a merge of 2041027
Summary: Tests failed: 1 (1 new), passed: 3317, ignored: 194 Build time: 00:56:26

Failed tests

org.jboss.as.test.integration.ejb.mdb.ejb2x.MDB20TopicTestCase.testEjb20TopicMDBs: java.lang.AssertionError: Reply message was null on reply queue: ActiveMQQueue[ejb2x/replyQueueA]
    at org.jboss.as.test.integration.ejb.mdb.ejb2x.MDB20TopicTestCase.testEjb20TopicMDBs(MDB20TopicTestCase.java:121)
------- Stdout: -------
 [0m19:35:30,487 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0028: Stopped deployment mdb.jar (runtime-name: mdb.jar) in 30ms
 [0m [0m19:35:30,491 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location /opt/buildAgent/work/db872761b443af46/full/testsuite/integration/basic/target/jbossas/standalone/data/content/e5/96b6ba266aa933cc75baac04ea008d9f7ec299/content
 [0m [0m19:35:30,491 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0009: Undeployed "mdb.jar" (runtime-name: "mdb.jar")
 [0m19:35:30,501 INFO  [org.jboss.as.test.integration.common.jms.JMSOperationsProvider] (main) Operation successful for update = {
    "operation" => "remove",
    "address" => [
        ("subsystem" => "messaging-activemq"),
        ("server" => "default"),
        ("jms-queue" => "ejb2x/queue")
    ]
}
19:35:30,512 INFO  [org.jboss.as.test.integration.common.jms.JMSOperationsProvider] (main) Operation successful for update = {
    "operation" => "remove",
    "address" => [
        ("subsystem" => "messaging-activemq"),
        ("server" => "default"),
        ("jms-queue" => "ejb2x/replyQueue")
    ]
}
19:35:30,518 INFO  [org.jboss.as.test.integration.ejb.mdb.ejb2x.AbstractMDB2xTestCase] (main) MDB20TopicTestCase.jar:
/org/
/org/jboss/
/org/jboss/as/
/org/jboss/as/test/
/org/jboss/as/test/integration/
/org/jboss/as/test/integration/ejb/
/org/jboss/as/test/integration/ejb/mdb/
/org/jboss/as/test/integration/ejb/mdb/ejb2x/
/org/jboss/as/test/integration/ejb/mdb/ejb2x/MDB20TopicTestCase$JmsQueueSetup.class
/org/jboss/as/test/integration/ejb/mdb/ejb2x/EJB2xMDB.class
/org/jboss/as/test/integration/ejb/mdb/ejb2x/AbstractMDB2xTestCase.class
/org/jboss/as/test/integration/common/
/org/jboss/as/test/integration/common/jms/
/org/jboss/as/test/integration/common/jms/JMSOperations.class
/org/jboss/as/test/integration/common/jms/JMSOperationsProvider.class
/org/jboss/as/test/integration/common/jms/ActiveMQProviderJMSOperations.class
/org/jboss/as/test/integration/common/jms/JMSOperationsException.class
/org/jboss/as/test/shared/
/org/jboss/as/test/shared/TimeoutUtil.class
/META-INF/
/META-INF/MANIFEST.MF
/META-INF/jboss-permissions.xml
/META-INF/ejb-jar.xml
/META-INF/jboss-ejb3.xml
 [0m19:35:30,552 INFO  [org.apache.activemq.artemis.core.server] (ServerService Thread Pool -- 4) AMQ221003: trying to deploy queue jms.topic.ejb2x/topic
 [0m19:35:30,629 INFO  [org.jboss.as.test.integration.common.jms.JMSOperationsProvider] (main) Operation successful for update = {
    "operation" => "add",
    "address" => [


@wildfly-ci
Copy link

Full integration - Windows Build 1308 outcome was FAILURE using a merge of 2041027
Summary: Execution timeout (new); tests passed: 3124, ignored: 194 Build time: 01:16:35

@bstansberry
Copy link
Contributor Author

retest this please

@wildfly-ci
Copy link

Full integration - Windows Build 1310 outcome was FAILURE using a merge of 2041027
Summary: Execution timeout; tests passed: 3123, ignored: 194 Build time: 01:16:04

@ctomc
Copy link
Contributor

ctomc commented Mar 23, 2016

@bstansberry while you are at it, I think we should @deprecate this class all together.
It is mostly used by tests and WS subsystem, which can be easily converted to PersistentRD
wdyt?

@bstansberry
Copy link
Contributor Author

I kind of like the class though. :) I'll think about it.

@bstansberry
Copy link
Contributor Author

This is used in 4 subsystems in full, so I'm not going to deprecate it here.

@kabir kabir added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Mar 30, 2016
@bstansberry bstansberry merged commit da8b13c into wildfly:master Mar 30, 2016
@bstansberry bstansberry deleted the WFCORE-1450 branch March 30, 2016 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
4 participants