[WFCORE-1456] Allow CLI class to support offline mode - REVERTED #1495
Conversation
|
Looks good. Thanks Jeff! |
|
|
||
| // Enable management | ||
| executeCommand(cli, "reload --admin-only=false"); | ||
|
|
There was a problem hiding this comment.
@jfdenise Sorry for coming in late on this. I think you may need to add a method to poll for the reload to be actually completed here, as it seems to be racing against itself. If I run in IDEA, the test always seems to pass, but running with mvn on the command line, it always seems to fail:
$ cd testsuite/standalone/
$ mvn test -Dtest=org.jboss.as.test.integration.management.cli.CLITestCase
What appears to be happening is that its trying to connect before the reload has completed.
If you take a look in ReloadHandler at the ensureServerRebootCompleted method, you'll see how that polls. We've recently added a new attribute runtime-configuration-state that should have the value "ok" when the reload is complete, which you can probably use here.
Some quick code if it helps: https://gist.github.com/luck3y/d563c3820c3e22c116327f4c5737bd58.
On a side note, I've often wondered about the immediate return of reload, it would seem more friendly if there was a way to have it block (perhaps as an optional parameter) until it was actually complete.
There was a problem hiding this comment.
We are aware of the issue and @jfdenise is going to follow up with a fix. Apparently, instead of the reload command, what gets executed is :reload operation, so the logic for making sure the controller is up in the reload handler is not run.
Sorry about that. And thanks for the tips!
There was a problem hiding this comment.
Great, thanks @aloubyansky and @jfdenise! Also, that makes a lot of sense now :)
There was a problem hiding this comment.
Yes, this test helped discover the CLI class behaviour, I am working on a patch to make CLI class to behave properly.
There was a problem hiding this comment.
The bug that is tracking the CLI command/operation mix: https://issues.jboss.org/browse/WFCORE-1471
kabir
changed the title
This fix allows to use the class in offline mode and connected mode. Furthermore these changes cover the issue reported in WFCORE-1417 ( CLI was not usable after a failing connect and error was wrongly reported).
CLI class has been refactored in order to reduce code replication and remove some formatting issues.
The existing API and expected behaviour has been preserved:
CLI cli = CLI.newInstance();
cli.connect(....);
The new behaviour:
CLI cli = CLI.newInstance();
cli.cmd("embed-server");
cli.connect(...);
cli.disconnect();
cli.cmd("embed-server"); || cli.connect(...);
cli.disconnect();
...