Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WFCORE-1857. No completion for invalid operation #1852

Merged
merged 1 commit into from Oct 20, 2016

Conversation

jfdenise
Copy link
Contributor

@jfdenise jfdenise commented Oct 7, 2016

When the candidates provider returns an empty list of arguments it can be caused by:

  • No arguments in the operation
  • An error occurred (invalid operation)

If the provider returns an empty list BUT the user has typed some content, then there is a mismatch. The empty list must have been caused by an error, so do not complete.

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 19, 2016
@bstansberry bstansberry merged commit 3aff76d into wildfly:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
2 participants