WFCORE-1841 lazy subsystem parser support #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ctomc
commented
Oct 18, 2016
ctomc
commented
- introduces parser providers (via staxmapper 1.3)
- migrates core subsystems to use it
- should reduce memory usage down a bit
ctomc
force-pushed
the
lazy-parser-init
branch
from
aa0e03f
to
1b10ebc
Compare
bstansberry
requested changes
Oct 19, 2016
| @@ -462,7 +463,8 @@ public static PersistentResourceXMLBuilder builder(final PathElement pathElement | |||
| protected boolean noAddOperation; | |||
| protected AdditionalOperationsGenerator additionalOperationsGenerator; | |||
| protected final LinkedList<AttributeDefinition> attributeList = new LinkedList<>(); | |||
| protected final List<PersistentResourceXMLBuilder> children = new ArrayList<>(); | |||
| final List<PersistentResourceXMLBuilder> childrenBuilder = new ArrayList<>(); | |||
| final List<PersistentResourceXMLDescription> children = new ArrayList<>(); | |||
There was a problem hiding this comment.
This changes the visibility of 'children'.
It's too bad this class isn't final and all of these aren't just private. There are no subclasses in core or full.
There was a problem hiding this comment.
yeah, this used to be all private, than David (I think) extended it, for some custom impl that could fit the security-manager subsystem.
Which was later "fixed" by adding required features to PersistentResourceXMLDescription and extended class removed.
I think we could probably make this class final again.
| @@ -462,7 +463,8 @@ public static PersistentResourceXMLBuilder builder(final PathElement pathElement | |||
| protected boolean noAddOperation; | |||
| protected AdditionalOperationsGenerator additionalOperationsGenerator; | |||
| protected final LinkedList<AttributeDefinition> attributeList = new LinkedList<>(); | |||
| protected final List<PersistentResourceXMLBuilder> children = new ArrayList<>(); | |||
| final List<PersistentResourceXMLBuilder> childrenBuilder = new ArrayList<>(); | |||
There was a problem hiding this comment.
Nit: 'childrenBuilders' is a better name as this is a collection.
| @@ -66,6 +67,9 @@ | |||
| */ | |||
| void setSubsystemXmlMapping(String subsystemName, String namespaceUri, XMLElementReader<List<ModelNode>> reader); | |||
|
|
|||
|
|
|||
| void setSubsystemXmlMapping(String subsystemName, String namespaceUri, Supplier<XMLElementReader<List<ModelNode>>> supplier); | |||
There was a problem hiding this comment.
Needs verbose javadoc.
There was a problem hiding this comment.
It was written, but lost in refactoring somewhere.
fixed.
ctomc
force-pushed
the
lazy-parser-init
branch
from
1b10ebc
to
c28c288
Compare
- introduces parser providers (via staxmapper 1.3) - migrates core subsystems to use it - should redurce memory usage down a bit
ctomc
force-pushed
the
lazy-parser-init
branch
from
c28c288
to
c4f2d7a
Compare
|
retest this please |
bstansberry
added
the
ready-for-merge
bstansberry
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.