Fix for WFCORE-1968. Fix write-attribute completion.

[jfdenise]

Remove completer dedicated to write-attribute value, was a partial replication of Operation completer. Replaced it with a shared completer used by all operation values.
Fixed a completion candidates sorting issue found accidentally.
Added unit test.

[wildfly-ci]

Core - Full Integration Build 3719 outcome was FAILURE using a merge of 65d49ce
Summary: Exit code 1 (new) Build time: 00:03:58

[wildfly-ci]

Full integration - Windows Build 2163 outcome was FAILURE using a merge of 65d49ce
Summary: Exit code 1 (new) Build time: 00:03:48

[wildfly-ci]

Core - Full Integration Build 3720 outcome was FAILURE using a merge of 65d49ce
Summary: Exit code 1 Build time: 00:01:37

[wildfly-ci]

Windows Build 4084 outcome was FAILURE using a merge of 65d49ce
Summary: Tests failed: 2 (2 new), passed: 3789, ignored: 89 Build time: 01:00:03

Failed tests

org.wildfly.core.test.standalone.mgmt.PreparedResponseTestCase.reloadServer: java.lang.RuntimeException: java.io.IOException: java.util.concurrent.CancellationException: Operation was cancelled
    at org.jboss.threads.AsyncFutureTask.operationCancelled(AsyncFutureTask.java:70)
    at org.jboss.threads.AsyncFutureTask.get(AsyncFutureTask.java:267)
    at org.jboss.as.controller.client.impl.AbstractDelegatingAsyncFuture.get(AbstractDelegatingAsyncFuture.java:57)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
    at org.wildfly.core.testrunner.ManagementClient.executeForResult(ManagementClient.java:234)
    at org.wildfly.core.test.standalone.mgmt.PreparedResponseTestCase.reloadServer(PreparedResponseTestCase.java:99)
------- Stdout: -------
14:53:44,152 INFO  [org.jboss.as.test.integration.management.extension.blocker.BlockerExtension] (management-handler-thread - 2) block requested by unknown for undefined/undefined(SERVICE_STOP)
14:53:44,152 INFO  [org.jboss.as.test.integration.management.extension.blocker.BlockerExtension] (management-handler-thread - 2) will block at SERVICE_STOP for 3000
14:53:44,168 INFO  [org.jboss.as.test.integration.management.extension.blocker.BlockerExtension] (MSC service thread 1-1) BlockService blocking in stop


org.wildfly.core.test.standalone.mgmt.PreparedResponseTestCase: java.lang.RuntimeException: java.io.IOException: java.net.ConnectException: WFLYPRT0053: Could not connect to remote+http://[0:0:0:0:0:0:0:1]:9990. The connection failed
    at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
    at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
    at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
    at org.xnio.nio.WorkerThread.run(WorkerThread.java:567)
    at ...asynchronous invocation...(Unknown Source)
    at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:438)
    at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:410)
    at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:406)
    at org.jboss.as.protocol.ProtocolConnectionUtils.connect(ProtocolConnectionUtils.java:166)
    at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:121)
    at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
    at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
    at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
    at org.jboss.as.controller.client.impl.RemotingModelControllerClient.getOrCreateChannel(RemotingModelControllerClient.java:135)
    at org.jboss.as.controller.client.impl.RemotingModelControllerClient$1.getChannel(RemotingModelControllerClient.java:59)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
    at org.wildfly.core.testrunner.ManagementClient.executeForResult(ManagementClient.java:234)
    at org.wildfly.core.test.standalone.mgmt.PreparedResponseTestCase.stopContainer(PreparedResponseTestCase.java:81)

[jfdenise]

retest this please!

[wildfly-ci]

Windows Build 4091 outcome was FAILURE using a merge of 65d49ce
Summary: Tests failed: 1 (1 new), passed: 3789, ignored: 89 Build time: 00:49:55

Failed tests

org.jboss.as.controller.test.TransactionalProtocolClientTestCase.testSimpleRequest: java.net.BindException: Address already in use: bind
    at sun.nio.ch.Net.bind0(Native Method)
    at sun.nio.ch.Net.bind(Net.java:433)
    at sun.nio.ch.Net.bind(Net.java:425)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
    at org.xnio.nio.NioXnioWorker.createTcpConnectionServer(NioXnioWorker.java:192)
    at org.xnio.XnioWorker.createStreamConnectionServer(XnioWorker.java:243)
    at org.jboss.remoting3.remote.RemoteConnectionProvider$ProviderInterface.createServer(RemoteConnectionProvider.java:348)
    at org.jboss.as.controller.support.ChannelServer.create(ChannelServer.java:92)
    at org.jboss.as.controller.test.TransactionalProtocolClientTestCase.startChannelServer(TransactionalProtocolClientTestCase.java:108)java.lang.NullPointerException: null
    at org.jboss.as.controller.test.TransactionalProtocolClientTestCase.stopChannels(TransactionalProtocolClientTestCase.java:142)

[wildfly-ci]

Full integration - Windows Build 2170 outcome was FAILURE using a merge of 65d49ce
Summary: Tests failed: 1 (1 new), passed: 3551, ignored: 172 Build time: 01:28:39

Failed tests

org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.testSimpleOverride: org.jboss.as.cli.CommandLineException: The controller is not available at [::1]:9999
    at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:131)
    at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
    at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
    at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
    at org.jboss.as.cli.impl.CLIModelControllerClient.getOrCreateChannel(CLIModelControllerClient.java:180)
    at org.jboss.as.cli.impl.CLIModelControllerClient$3.getChannel(CLIModelControllerClient.java:132)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
    at org.jboss.as.cli.impl.CommandContextImpl.tryConnection(CommandContextImpl.java:1296)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1142)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1181)
    at org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.setUp(DomainDeploymentOverlayTestCase.java:147)
------- Stdout: -------
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).

[wildfly-ci]

Full integration - Windows Build 2191 outcome was FAILURE using a merge of 65d49ce
Summary: Tests failed: 1 (1 new), passed: 3551, ignored: 172 Build time: 01:29:43

Failed tests

org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.testSimpleOverrideWithRedeployAffected: org.jboss.as.cli.CommandLineException: The controller is not available at [::1]:9999
    at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:131)
    at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
    at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
    at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
    at org.jboss.as.cli.impl.CLIModelControllerClient.getOrCreateChannel(CLIModelControllerClient.java:180)
    at org.jboss.as.cli.impl.CLIModelControllerClient$3.getChannel(CLIModelControllerClient.java:132)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
    at org.jboss.as.cli.impl.CommandContextImpl.tryConnection(CommandContextImpl.java:1296)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1142)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1181)
    at org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.setUp(DomainDeploymentOverlayTestCase.java:147)
------- Stdout: -------
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).

[bstansberry]

@aloubyansky please approve

[aloubyansky]

Looks good. Thanks!