Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WFCORE-1982. Invalid argument/property handling. #1942

Merged
merged 1 commit into from Nov 18, 2016

Conversation

jfdenise
Copy link
Contributor

Applying replacements could fail for invalid arguments/properties and break the validate/not validate operation feature.
Added unit test.

@wildfly-ci
Copy link

Full integration - Windows Build 2194 outcome was FAILURE using a merge of a78cefb
Summary: Tests failed: 1 (1 new), passed: 3569, ignored: 172 Build time: 01:25:01

Failed tests

org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.testMultipleLinks: org.jboss.as.cli.CommandLineException: The controller is not available at [::1]:9999
    at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:131)
    at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
    at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
    at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
    at org.jboss.as.cli.impl.CLIModelControllerClient.getOrCreateChannel(CLIModelControllerClient.java:180)
    at org.jboss.as.cli.impl.CLIModelControllerClient$3.getChannel(CLIModelControllerClient.java:132)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
    at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
    at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
    at org.jboss.as.cli.impl.CommandContextImpl.tryConnection(CommandContextImpl.java:1296)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1142)
    at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1181)
    at org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.setUp(DomainDeploymentOverlayTestCase.java:147)
------- Stdout: -------
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).


@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Nov 18, 2016
@bstansberry bstansberry merged commit a0ba979 into wildfly:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
3 participants