[WFCORE-2080] Instantiating the WildFlyElytronProvider is an expensive operation so only do it once.

[darranl]

❗ Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. ❗

https://issues.jboss.org/browse/WFCORE-2080

[bstansberry]

This could use a comment as to why it's ok to store a mutable class in a static field. (I looked at how it's used and it's only read after construction so it's ok, but 4 years from now someone else will ask the same question.)

[darranl]

Thinking about this I can probably get away with moving this into the service lifecycle, the reported problem was it was being created per request.

[ctomc]

As long as it is not created in both providers directly it is fine.
I was testing locally by just having
Provider[] providers = new Provider[]{new WildFlyElytronProvider()}
in service code and than returning that in both providers.

[wildfly-ci]

Windows Build 4331 outcome was FAILURE using a merge of 0453d06
Summary: Tests failed: 1 (1 new), passed: 3863, ignored: 74 Build time: 01:06:26

Failed tests

org.jboss.as.controller.test.TransactionalProtocolClientTestCase.testConcurrentGroup: java.net.BindException: Address already in use: bind
	at sun.nio.ch.Net.bind0(Native Method)
	at sun.nio.ch.Net.bind(Net.java:433)
	at sun.nio.ch.Net.bind(Net.java:425)
	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
	at org.xnio.nio.NioXnioWorker.createTcpConnectionServer(NioXnioWorker.java:192)
	at org.xnio.XnioWorker.createStreamConnectionServer(XnioWorker.java:243)
	at org.jboss.remoting3.remote.RemoteConnectionProvider$ProviderInterface.createServer(RemoteConnectionProvider.java:349)
	at org.jboss.as.controller.support.ChannelServer.create(ChannelServer.java:92)
	at org.jboss.as.controller.test.TransactionalProtocolClientTestCase.startChannelServer(TransactionalProtocolClientTestCase.java:108)java.lang.NullPointerException: null
	at org.jboss.as.controller.test.TransactionalProtocolClientTestCase.stopChannels(TransactionalProtocolClientTestCase.java:142)

[wildfly-ci]

Full integration - Windows Build 2396 outcome was FAILURE using a merge of 0453d06
Summary: Tests failed: 6 (6 new), passed: 3454, ignored: 116 Build time: 01:17:11

Failed tests

org.jboss.as.test.integration.domain.mixed.eap640.KernelBehavior640TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_6_4_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.KernelBehaviorTestSuite.getSupport(KernelBehaviorTestSuite.java:40)
	at org.jboss.as.test.integration.domain.mixed.eap640.KernelBehavior640TestSuite.initializeDomain(KernelBehavior640TestSuite.java:42)


org.jboss.as.test.integration.domain.mixed.eap640.LegacyConfig640TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_6_4_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupportForLegacyConfig(MixedDomainTestSuite.java:75)
	at org.jboss.as.test.integration.domain.mixed.eap640.LegacyConfig640TestSuite.initializeDomain(LegacyConfig640TestSuite.java:37)


org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_6_4_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:59)
	at org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite.initializeDomain(MixedDomain640TestSuite.java:44)


org.jboss.as.test.integration.domain.mixed.eap700.KernelBehavior700TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_7_0_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.KernelBehaviorTestSuite.getSupport(KernelBehaviorTestSuite.java:40)
	at org.jboss.as.test.integration.domain.mixed.eap700.KernelBehavior700TestSuite.initializeDomain(KernelBehavior700TestSuite.java:42)


org.jboss.as.test.integration.domain.mixed.eap700.LegacyConfig700TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_7_0_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupportForLegacyConfig(MixedDomainTestSuite.java:75)
	at org.jboss.as.test.integration.domain.mixed.eap700.LegacyConfig700TestSuite.initializeDomain(LegacyConfig700TestSuite.java:37)


org.jboss.as.test.integration.domain.mixed.eap700.MixedDomain700TestSuite: java.lang.AssertionError: expected:<EAP_6_3_0> but was:<EAP_7_0_0>
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getVersion(MixedDomainTestSuite.java:45)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:83)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:59)
	at org.jboss.as.test.integration.domain.mixed.eap700.MixedDomain700TestSuite.initializeDomain(MixedDomain700TestSuite.java:44)