Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-2178 throw exception with failure description if overlay resou… #2069

Closed
wants to merge 1 commit into from

Conversation

soul2zimate
Copy link
Contributor

…rce does not exist.
https://issues.jboss.org/browse/WFCORE-2178
In case of non-existent deployment overlay, CommandLineException with failure description should call attention to user instead of returning an empty list in silence.

On CLI side, print something like:

[standalone@localhost:9990 /] deployment-overlay list-links --name=not-existing-overlay   
WFLYCTL0216: Management resource '[("deployment-overlay" => "not-existing-overlay")]' not found

[domain@localhost:9990 /] deployment-overlay list-links --name=not-existing-overlay
WFLYCTL0216: Management resource '[
    ("server-group" => "main-server-group"),
    ("deployment-overlay" => "not-existing-overlay")
]' not found

@jfdenise
Copy link
Contributor

Hi, the PR #2044 is already addressing the overlay error messages for all requests. It is not merged yet. Will be soon.
Thank-you.
JF

@wildfly-ci
Copy link

Core - Full Integration Build 4119 outcome was FAILURE using a merge of f760f0a
Summary: Tests failed: 1 (1 new), passed: 3647, ignored: 109 Build time: 00:50:24

Failed tests

org.jboss.as.test.integration.jmx.ModelControllerMBeanTestCase.testAllMBeanInfos: java.lang.AssertionError: {jboss.as:core-service=management,service=management-operations,active-operation=-518294698=javax.management.InstanceNotFoundException: jboss.as:core-service=management,service=management-operations,active-operation=-518294698}
	at org.jboss.as.test.integration.jmx.ModelControllerMBeanTestCase.testAllMBeanInfos(ModelControllerMBeanTestCase.java:92)
------- Stdout: -------
01:01:51,903 WARN  [org.jboss.remotingjmx.Util] (main) The protocol 'http-remoting-jmx' is deprecated, instead you should use 'remote+http'.
01:01:51,903 WARN  [org.jboss.remotingjmx.Util] (main) The protocol 'http-remoting-jmx' is deprecated, instead you should use 'remote+http'.


@soul2zimate
Copy link
Contributor Author

Didn't see that PR, I guess I will close this one and mark https://issues.jboss.org/browse/JBEAP-7363 and https://issues.jboss.org/browse/WFCORE-2178 as duplicates, Is that ok to you?

@jfdenise
Copy link
Contributor

Hi, yes that would be fine!
JF

@soul2zimate
Copy link
Contributor Author

superseded by an early fix in #2044

@soul2zimate soul2zimate deleted the WFCORE-2178 branch January 13, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants