Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-2066 Kill and destroy operations on the server-group #2182

Merged
merged 2 commits into from Nov 14, 2017

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Feb 12, 2017

This issue adds Kill and Destroy operations at server-group level. It adds some refactored code in ManagedServer#ServerStopTask and removes an unused operation-id from it.

Jira issue is:
https://issues.jboss.org/browse/WFCORE-2066

@yersan yersan changed the title Enhancements/wfcore 2066 WFCORE-2066 Kill and destroy operations on the server-group Feb 12, 2017
@yersan
Copy link
Collaborator Author

yersan commented Feb 14, 2017

retest this please

@bstansberry
Copy link
Contributor

Re: the test failures, we've added notifications of lifecycle changes and tests that assert the notifications are being emitted in the patterns we expect. So perhaps there is a problem with this PR or perhaps the tests are assuming something invalid. I haven't investigated.

The PR seems ok but will need to have transformers added, as slave HCs running previous versions will not be able to handle these new operations. The ServerGroupTransformers class is handling registering those. It will need to be a bit different from what is there though, as what is there is for transforming to slaves running kernel management API version 1.8 and earlier (i.e. <= EAP 6.4) while this will need to be for version 4.1 and earlier.

@yersan yersan force-pushed the enhancements/WFCORE-2066 branch 2 times, most recently from 6dda96d to 2e2cde7 Compare February 19, 2017 11:50
@yersan
Copy link
Collaborator Author

yersan commented Feb 19, 2017

All test pass without any issues in my local computer. Let's try again.

retest this please

@yersan
Copy link
Collaborator Author

yersan commented Feb 20, 2017

retest this please

1 similar comment
@yersan
Copy link
Collaborator Author

yersan commented Feb 20, 2017

retest this please

@bstansberry
Copy link
Contributor

The transformer stuff looks ok. This will need to be held of WF Core 4 though, at which time there will be a new version (i.e. target would be VERSION_5_0 instead of VERSION_4_1). Might as well let this wait until we open up for work on 4 and then we can set the exact version.

@kabir I could use some re-education on these transformer chains. We have a version 4.2 now (WF 10.1) that we should transform to. Does simply replacing any chained build aiming at VERSION_4_1 with VERSION_4_2 automatically handle 4.1 as well?

@yersan
Copy link
Collaborator Author

yersan commented Mar 3, 2017

Branch rebased to resolve conflicts with master

@yersan
Copy link
Collaborator Author

yersan commented Nov 8, 2017

  • Transformers have been updated accoring to the current version
  • Added a unit test to test the kill/destroy servers transformers

@bstansberry bstansberry merged commit 1b875df into wildfly:master Nov 14, 2017
@yersan yersan deleted the enhancements/WFCORE-2066 branch November 15, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants