[WFCORE-2332] ReloadRedirectTestCase stuck on HP-UX #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfdenise please approve |
jfdenise
reviewed
Feb 27, 2017
| @@ -226,6 +226,7 @@ public void testReloadwithRedirect() throws Exception { | |||
| promptFound = cliProc.pushLineAndWaitForResults("reload", "Accept certificate"); | |||
| assertTrue("No certificate prompt " + cliProc.getOutput(), promptFound); | |||
| } finally { | |||
| cliProc.ctrlCAndWaitForClose(); | |||
| cliProc.destroyProcess(); | |||
There was a problem hiding this comment.
@pkremens , not sure you need to call destroyProcess once CtrlC has been sent. ctrlCAndWaitForClose() should be enough.
There was a problem hiding this comment.
@jfdenise good point, I'll try on Windows and some exotic platforms we certify to be sure, and update the PR in case CtrlC is enough. Thank you.
There was a problem hiding this comment.
I noticed that on Solaris10 sparc that cliProc is not completely destroyed using just cliProc.destroyProcess(); - test pass, maven execution successfully ends, but a running cli process remains. Using just CtrlC works fine.
cliProcess.destroy() does stuck on HP-UX if cliProcess is waiting for input from user (accept certificate dialogue)
pkremens
force-pushed
the
wfcore-2332
branch
from
a4c2094
to
c56f650
Compare
bstansberry
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cliProcess.destroy() does stuck on HP-UX if cliProcess is waiting for input from user (accept certificate dialogue)
https://issues.jboss.org/browse/WFCORE-2332 - ReloadRedirectTestCase stuck on HP-UX