Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WFCORE-2347. Intermittent failure of some CLI tests. #2220

Merged
merged 1 commit into from Mar 3, 2017

Conversation

jfdenise
Copy link
Contributor

@jfdenise jfdenise commented Mar 1, 2017

The test that is failing in the bug report is FileArgumentTestCase.java but FileWithPropertiesTestCase.java could be affected by the same problem. Both tests have been refactored similarly.
I suspect that using commonly used CliProcessWrapper to interact with the CLI would make these intermitent failures to vanish. This would have to be validated over time in QA context.
This fix is an attempt.

@bstansberry
Copy link
Contributor

I approved this but have a question:

Should CliCommandBuilder be fixed in some way? Not as an alternative solution for this JIRA or as a priority; just should we file a JIRA to fix something? IOW is CliCommandBuilder launching the CLI incorrectly, or is this just a matter of using CliProcessWrapper as it makes it possible to better handle other things besides launch.

@jfdenise
Copy link
Contributor Author

jfdenise commented Mar 3, 2017

CliCommandBuilder is a fine class. In this case we had tests that were reimplementing the logic present in CLIProcessWrapper (CLIProcessWrapper uses CliCommandBuilder).

I noticed the class CustomCLIExecutor that does something similar to CLIProcessWrapper but add some logic to it (in the context of triaging JBEAP-4013). We could end by aligning all tests to use CLIProcessWrapper, but I am pretty we would have to make changes to CLIProcessWrapper to handle fully what tests are doing with CustomCLIExecutor.

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Mar 3, 2017
@bstansberry bstansberry merged commit 2526d70 into wildfly:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
2 participants