Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-2626] Execute interface criteria in configured order, but put… #2315

Merged
merged 1 commit into from Apr 13, 2017

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Apr 5, 2017

… InetAddressMatchInterfaceCriteria last so the AS7-4509 solution doesn't fail due to duplicates that other criteria would discard.

https://issues.jboss.org/browse/WFCORE-2626

This PR is a bit of overkill, but probably worth it:

  1. It preserves the order of interface match criteria the user specifies, so the user gets some control. Probably not necessary given 2), but seems like a good idea.
  2. Overrides 1) by sorting InetAddressMatchInterfaceCriteria last, giving other criteria a chance to eliminate dups before it checks for them.

Note this ordering thing has nothing to do with xml persistence; it's just about use of the configured data in the runtime. We always persisted in order.

Just 1) would be sufficient so long as users put <inet-address> after other things. Just 2) would be sufficient but 1) seemed like a good idea anyway.

… InetAddressMatchInterfaceCriteria last so the AS7-4509 solution doesn't fail due to duplicates that other criteria would discard.
Copy link
Contributor

@luck3y luck3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me +1.

@bstansberry bstansberry merged commit 8fd4d26 into wildfly:master Apr 13, 2017
@bstansberry bstansberry deleted the WFCORE-2626 branch April 13, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants