Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for WFCORE-2667. Invalid CLI exit code on Windows #2334

Merged
merged 1 commit into from Apr 19, 2017
Merged

Fix for WFCORE-2667. Invalid CLI exit code on Windows #2334

merged 1 commit into from Apr 19, 2017

Conversation

jfdenise
Copy link
Contributor

This issue is revealed by usage of cmd /C. error level vraiable was not properly evaluated.

@bstansberry
Copy link
Contributor

Please find someone competent to review this. :)

@jfdenise
Copy link
Contributor Author

@ctomc seems the script expert, in case you have few cycles to give it an eye. Thanks!
JF

ctomc
ctomc approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@ctomc ctomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !VAR! syntax is used when setlocal ENABLEDELAYEDEXPANSION is enabled, which is done at L81
and probably explains why it is still needed here.

But all in all it looks ok.

@bstansberry bstansberry merged commit d93e510 into wildfly:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctomc ctomc ctomc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jfdenise @bstansberry @ctomc