Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-2754] Port the sasl-mechanism selector attribute to the elytr… #2454

Closed
wants to merge 1 commit into from
Closed

[WFCORE-2754] Port the sasl-mechanism selector attribute to the elytr… #2454

wants to merge 1 commit into from

Conversation

sguilhen
Copy link
Contributor

darranl
darranl requested changes May 23, 2017
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small change though - I think we should make the sasl mechanism selector attribute and the allow and forbid attributes all mutually exclusive to each other as the AuthenticationConfiguration now only allows one to be defined at a time.

hkalina
hkalina suggested changes May 23, 2017
View reviewed changes
Copy link

@hkalina hkalina left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except KERBEROS_SECURITY_FACTORY removing from attributes (which looks accidentally) looks ok for me.

elytron/src/main/java/org/wildfly/extension/elytron/AuthenticationClientDefinitions.java

static final AttributeDefinition[] AUTHENTICATION_CONFIGURATION_ALL_ATTRIBUTES = new AttributeDefinition[] { CONFIGURATION_EXTENDS, ANONYMOUS, AUTHENTICATION_NAME, AUTHORIZATION_NAME, HOST, PROTOCOL,
PORT, REALM, SECURITY_DOMAIN, ALLOW_ALL_MECHANISMS, ALLOW_SASL_MECHANISMS, FORBID_SASL_MECHANISMS, KERBEROS_SECURITY_FACTORY, MECHANISM_PROPERTIES, CREDENTIAL_REFERENCE };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is KERBEROS_SECURITY_FACTORY removed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn´t have been removed, good catch @honza889

@kabir kabir mentioned this pull request May 23, 2017
Merged
@kabir
Copy link
Contributor

kabir commented May 23, 2017

Fixed up in #2455

@kabir kabir closed this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl requested changes

@hkalina hkalina hkalina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sguilhen @kabir @darranl @hkalina