Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-2891] attribute "required" into elytron kerberos-security-factory #2486

Merged
merged 1 commit into from Jun 6, 2017

Conversation

@wildfly-ci
Copy link

Core - Full Integration Build 5096 outcome was FAILURE using a merge of 0f587b6
Summary: Compilation error: Compiler (new) Build time: 00:00:41

@wildfly-ci
Copy link

Full integration - Windows Build 3514 outcome was FAILURE using a merge of 0f587b6
Summary: Compilation error: Compiler (new) Build time: 00:02:45

@kabir
Copy link
Contributor

kabir commented Jun 1, 2017

Retest this please

@wildfly-ci
Copy link

Core - Full Integration Build 5104 outcome was FAILURE using a merge of 0f587b6
Summary: Compilation error: Compiler Build time: 00:00:48

@wildfly-ci
Copy link

Full integration - Windows Build 3521 outcome was FAILURE using a merge of 0f587b6
Summary: Compilation error: Compiler Build time: 00:02:37

Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@honza889 The parsing/marshalling needs to be tested in the subsystem tests. Looking at usage of the 'sibling' attribute wrap-gss-credential, I think you need to add this new required attribute to elytron/src/test/resources/org/wildfly/extension/elytron/credential-security-factories.xm

@wildfly-ci
Copy link

Core - Full Integration Build 5105 outcome was FAILURE using a merge of 2f227c0
Summary: Compilation error: Compiler Build time: 00:00:36

@wildfly-ci
Copy link

Full integration - Windows Build 3522 outcome was FAILURE using a merge of 2f227c0
Summary: Compilation error: Compiler Build time: 00:01:56

@kabir
Copy link
Contributor

kabir commented Jun 5, 2017

Retest this please

@hkalina
Copy link
Author

hkalina commented Jun 6, 2017

Hmmm... probably just flaky tests, but will try to investigate the windows failure...

@kabir kabir merged commit c1107d1 into wildfly:master Jun 6, 2017
@hkalina hkalina deleted the WFCORE-2891 branch June 7, 2017 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants