New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-2891] attribute "required" into elytron kerberos-security-factory #2486
Conversation
Core - Full Integration Build 5096 outcome was FAILURE using a merge of 0f587b6 |
Full integration - Windows Build 3514 outcome was FAILURE using a merge of 0f587b6 |
Retest this please |
Core - Full Integration Build 5104 outcome was FAILURE using a merge of 0f587b6 |
Full integration - Windows Build 3521 outcome was FAILURE using a merge of 0f587b6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@honza889 The parsing/marshalling needs to be tested in the subsystem tests. Looking at usage of the 'sibling' attribute wrap-gss-credential, I think you need to add this new required attribute to elytron/src/test/resources/org/wildfly/extension/elytron/credential-security-factories.xm
Core - Full Integration Build 5105 outcome was FAILURE using a merge of 2f227c0 |
Full integration - Windows Build 3522 outcome was FAILURE using a merge of 2f227c0 |
Retest this please |
Hmmm... probably just flaky tests, but will try to investigate the windows failure... |
https://issues.jboss.org/browse/WFCORE-2891
https://issues.jboss.org/browse/JBEAP-10653
Depends on wildfly-security/wildfly-elytron#849