[WFCORE-2876]: Runtime-failure-causes-rollback does not seem to have effect when configured in model #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
reviewed
Jun 1, 2017
| @@ -274,7 +274,7 @@ public void run() { | |||
| assert scheduledExecutor != null; | |||
| assert deploymentDir != null; | |||
|
|
|||
| this.resourceAddress = resourceAddress.toModelNode(); | |||
| this.resourceAddress = resourceAddress.toModelNode(); | |||
There was a problem hiding this comment.
The tests are failing so you'll need to update this branch to fix that, so might as well correct this whitespace. :)
…effect when configured in model The runtime-failure-causes-rollback wasn't properly propagated to the boot scanner. If runtime-failure-causes-rollback is set to 'false' then failed deployments added at boot shouldn't be undeployed.
|
Core - Full Integration Build 5169 outcome was FAILURE using a merge of 0066f92 |
|
retest this please |
1 similar comment
|
retest this please |
|
Core - Full Integration Build 5222 outcome was FAILURE using a merge of 0066f92 |
|
retest this please |
bstansberry
approved these changes
Jun 13, 2017
bstansberry
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime-failure-causes-rollback wasn't properly propagated to the boot scanner.
If runtime-failure-causes-rollback is set to 'false' then failed deployments added at boot shouldn't be undeployed.
Jira: https://issues.jboss.org/browse/WFCORE-2876