New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for WFCORE-2926. Disable error-on-interract for CLI.connect. #2518
Conversation
Core - Full Integration Build 5173 outcome was FAILURE using a merge of b8311bd |
Full integration - Windows Build 3582 outcome was FAILURE using a merge of b8311bd Failed tests
|
Core - Full Integration Build 5174 outcome was FAILURE using a merge of b8311bd |
retest this please!! |
Core - Full Integration Build 5176 outcome was FAILURE using a merge of b8311bd |
CLI class connect method should set ignoreOnInteract to false.
In addition I added a connect method to allow to provide a CommandContextConfiguration. This class is in an impl package but has already been exposed as a public API in the CommandContextFactory. I wanted to move it to public API, but being already exposed we can't change its location.