New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-2943] set required to false for storage runtime attributes in… #2532
Conversation
… elytron loaded-providers.
Full integration - Windows Build 3617 outcome was FAILURE using a merge of 0220429 Failed tests
|
Core - Full Integration Build 5230 outcome was FAILURE using a merge of 0220429 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok, but not because these are runtime-only attributes. It's ok for a runtime-only attribute to be required. (They can have an undefined value in a response if the read-resource op doesn't include the include-runtime=true param, but that doesn't count in terms of the attribute being "required" or not. The "storage" metadata for the attribute covers that.)
These should be required=false because looking at the read handler impls it looks like the user can use include-runtime=true and still get an undefined value for these, i.e. if the relevant service is not up.
… elytron loaded-providers.
WFCORE https://issues.jboss.org/browse/WFCORE-2943
JBEAP https://issues.jboss.org/browse/JBEAP-9848
set required to false for storage runtime attributes in elytron loaded-providers.