[WFCORE-2942] Adding credential-reference with non-exist alias to aut… #2535
Conversation
| if (passCredential == null && alias != null && alias.length() > 0) { | ||
| throw ROOT_LOGGER.credentialDoesNotExist(alias, PasswordCredential.class.getName()); | ||
| } | ||
| return c.usePassword(passCredential.getPassword()); |
There was a problem hiding this comment.
This can still NPE if alias == null, although perhaps it's not really possible for passCredential to be null if alias is null. (I haven't looked to see.)
There was a problem hiding this comment.
The alias is required in this situation, but for thoroughly checking, I agree it will be better to check the case as well. :)
| if (e.getCause() != null) { | ||
| throw new StartException(e.getCause().getMessage()); | ||
| } | ||
| throw new StartException(e.getMessage()); |
There was a problem hiding this comment.
I think both of these throws would be better if they included a cause so the stack trace is more useful.
There was a problem hiding this comment.
Yes, it is.
I decided to discard the cause because both CLI and server log will print the error message twice, like:
{
"outcome" => "failed",
"failure-description" => {"WFLYCTL0080: Failed services" => {"org.wildfly.security.authentication-configuration.cfg2" => "WFLYELY00004: Unable to start the service.
Caused by: org.jboss.as.controller.OperationFailedException: WFLYELY00920: Credential alias \"d\" of credential type \"org.wildfly.security.credential.PasswordCredential\" does not exist in the store [ \"WFLYELY00920: Credential alias \\\"d\\\" of credential type \\\"org.wildfly.security.credential.PasswordCredential\\\" does not exist in the store\" ]"}},
"rolled-back" => true
}
but it should be another issue if you agree, I will add the cause back for the accurate stack trace.
…hentication-configuration through CLI results to NPE
|
Updated according to the comments. :) |
bstansberry
added
the
ready-for-merge
…hentication-configuration through CLI results to NPE
Jira: https://issues.jboss.org/browse/WFCORE-2942