[WFCORE-189] Provide a proper detail message when creating an OFE #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me |
| @@ -78,7 +78,7 @@ public void execute(OperationContext context, ModelNode operation) throws Operat | |||
| } | |||
| } | |||
| catch (IOException e) { | |||
| throw new OperationFailedException(new ModelNode().set(e.toString())); | |||
| throw new RuntimeException(e); | |||
There was a problem hiding this comment.
It might not be very important, but why the changed type of exception?
There was a problem hiding this comment.
@kabir thanks for asking, as I'd like a second opinion. And I shouldn't have made this change here anyway, as it's a bit OT to the overall PR.
I changed it because OFE is meant to represent a client failure, not a server fault. And I don't see how an IOException is a client failure.
OTOH...
- the standalone variant of this throws OFE, so these should be consistent one way or the other
org.jboss.as.server.deployment.AbstractDeploymentUploadHandler
catch (IOException e) {
throw ServerLogger.ROOT_LOGGER.caughtIOExceptionUploadingContent(e);
}
- the basic difference between RuntimeException and OFE is the former will end up in the server log. Also, if we end up providing proper HTTP response codes, the former will result in a 500 while the latter will result in a 400. But for both of those issues, maybe the OFE result is better?
There was a problem hiding this comment.
I'm going to switch it back to an OFE, built the same as the standalone variant.
bstansberry
force-pushed
the
WFCORE-189
branch
from
456e321
to
7868200
Compare
bstansberry
force-pushed
the
WFCORE-189
branch
from
7868200
to
c6c0fc7
Compare
bstansberry
added a commit
that referenced
this pull request
Nov 1, 2014
[WFCORE-189] Provide a proper detail message when creating an OFE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.