[WFCORE-3187] add-user.sh tool prints unexpected characters if arrow keys are pushed during interactive mode #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
MMarus
force-pushed
the
add-user-fixes
branch
2 times, most recently
from
78d45d0
to
4d35dc8
Compare
xstefank
reviewed
Aug 18, 2017
| try { | ||
| createTerminalConnection(readLineHandler); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
this should log a proper error - you can find an example on the line 65 before change
| assertEquals(Thread.State.TERMINATED, aeshJavaConsoleTestResource.getState()); | ||
| } | ||
|
|
||
| public class AeshJavaConsoleTestResource extends Thread { |
There was a problem hiding this comment.
public inner classes are generally considered as not a good practice, is there any reason this class needs to be public? Also please make it static
…keys are pushed during interactive mode
|
I think this one will be easier to review after a rebase. |
bstansberry
added
rebase-this
|
I moved this PR to a new rebased PR #3064 for easier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBEAP: https://issues.jboss.org/browse/JBEAP-6640
WFCORE: https://issues.jboss.org/browse/WFCORE-3187
Please DON'T merge before #2533 is merged, since this pull request requires changes introduced in #2533 .