[WFCORE-3239] CLIWrapper does not allow for use in multinode tests #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfdenise Please approve. This is fairly urgent. I don't like how the new method at https://github.com/wildfly/wildfly-core/pull/2762/files#diff-29e0b52627e394ccbfffa4de316f5944R146 results in different connect logic from what's in the current code at L111. That is, why doesn't the current L111 method call into the new method? A good argument for not changing the L111 method in 3.x/3.0.x is to not not change any existing behavior at this late date, just add new for this specific test. But for master we can make it work the way we want it to be for the long term. |
jfdenise
approved these changes
Sep 5, 2017
|
OK, let's clean that part up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFCORE-3239