Fix for WFCORE-3363, CLI to output JSON #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full integration - Windows Build 4458 outcome was FAILURE using a merge of 518a148 |
|
Full integration - Windows Build 4461 outcome was FAILURE using a merge of 518a148 |
bstansberry
reviewed
Oct 27, 2017
cli/src/main/resources/help/help.txt
Outdated
| @@ -97,6 +98,9 @@ Usage: | |||
| --command-timeout - The maximum amount of seconds the CLI will wait for a | |||
| command to complete. | |||
|
|
|||
| --output-json - makes the CLI to display operation responses using JSON syntax. | |||
|
Minor language thing in the help text aside, looks good! |
|
Full integration - Windows Build 4485 outcome was FAILURE using a merge of 2b5e7c1 |
bstansberry
reviewed
Oct 31, 2017
| @@ -89,7 +89,7 @@ public void handle(CommandContext ctx) throws CommandLineException { | |||
| try { | |||
| final ModelNode result = ctx.execute(op, "Operation request"); | |||
| if (Util.isSuccess(result)) { | |||
| ctx.printLine(result.toString()); | |||
| ctx.printDMR(result); | |||
| } else { | |||
| throw new CommandLineException(result.toString()); | |||
There was a problem hiding this comment.
I commented on https://developer.jboss.org/wiki/CLI-OutputJSON re: exception handling (i.e. I think this is right.)
bstansberry
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community doc PR: Some CLI new features doc wildfly#10798