Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WFCORE-3442, reload with changed authentication configuration #2971

Merged
merged 1 commit into from Dec 11, 2017

Conversation

jfdenise
Copy link
Contributor

@jfdenise jfdenise commented Dec 5, 2017

Makes the reload handler to attempt a reconnect if authentication failed. This will give a change to provide new credentials.
Added unit test.

@bstansberry
Copy link
Contributor

11.5 more seconds in another manual mode test. :(

To be fair, dealing with this one in the main test suite would be problematic, as there is the risk that the server is left all screwed up if it fails, with later tests unable to connect.

Hmm, could this set up a native-interface and use that instead of altering the http-interface?

An alternative is to set up a native-interface and use that for setup/cleanup so you know it will be available for cleanup even if the http-interface is left in a broken state due to a failure. But that sounds like too much work.

@jfdenise
Copy link
Contributor Author

jfdenise commented Dec 6, 2017

With respect to putting the server into an invalid state if something goes wrong, in any case the standalone.xml will be put back to its original state.
@BeforeClass first thing is to copy the original standalone.xml. @afterclass (called in all cases) first thing is to replace the updated standalone.xml file with a clean one copied in @BeforeClass.

With respect to the time spent in this test, I am ready to move it where it would make more sense.

@jfdenise
Copy link
Contributor Author

jfdenise commented Dec 7, 2017

The test has been moved to standalone and rewritten to do explicit cleanup of the server state. Time is now 2secs.

@bstansberry bstansberry merged commit 3449abf into wildfly:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants