Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-3541] ScramDigestPassword into set-password operation #3066

Merged
merged 1 commit into from Feb 10, 2018

Conversation

hkalina
Copy link

@hkalina hkalina commented Jan 25, 2018

Elytron security:
Adding scram password support into set-password operation of modifiable security realms.

https://issues.jboss.org/browse/WFCORE-3541

@wildfly-ci
Copy link

Core - Full Integration Build 6517 outcome was FAILURE using a merge of eaa64fc
Summary: Tests failed: 1 (1 new), passed: 4161, ignored: 142 Build time: 01:27:52

Failed tests

org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: javax.xml.ws.WebServiceException: Could not send Message.
	at org.apache.cxf.jaxws.JaxWsClientProxy.invoke(JaxWsClientProxy.java:150)
	at com.sun.proxy.$Proxy102.sayHello(Unknown Source)
	at org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn(SignEncryptMultipleClientsTestCase.java:103)
Caused by: java.net.SocketException: SocketException invoking http://[::1]:8080/jaxws-wsse-sign-encrypt-mc/EncryptSecurityService: Socket closed
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.mapException(HTTPConduit.java:1390)
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1374)
	at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
	at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:658)
	at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSenderInterceptor.java:62)
	at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
	at org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:518)
	at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:427)
	at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:328)
	at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:281)
	at org.apache.cxf.frontend.ClientProxy.invokeSync(ClientProxy.java:96)
	at org.apache.cxf.jaxws.JaxWsClientProxy.invoke(JaxWsClientProxy.java:139)
	... 128 more
Caused by: java.net.SocketException: Socket closed
	at java.net.SocketInputStream.read(SocketInputStream.java:204)
	at java.net.SocketInputStream.read(SocketInputStream.java:141)
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
	at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
	at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
	at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:735)
	at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:678)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1587)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at org.apache.cxf.transport.http.URLConnectionHTTPConduit$URLConnectionWrappedOutputStream.getResponseCode(URLConnectionHTTPConduit.java:370)
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.doProcessResponseCode(HTTPConduit.java:1587)
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1616)
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1560)
	at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1361)
	... 138 more
------- Stdout: -------
 [0m05:59:46,735 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 29) WFLYUT0022: Unregistered web context: '/jaxws-wsse-sign-encrypt' from server 'default-server'
 [0m [0m05:59:46,736 INFO  [org.jboss.as.webservices] (MSC service thread 1-3) WFLYWS0004: Stopping service jboss.ws.endpoint."jaxws-wsse-sign-encrypt.jar".EJBEncryptServiceImpl
 [0m [0m05:59:46,743 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-4) WFLYSRV0028: Stopped deployment jaxws-wsse-sign-encrypt.jar (runtime-name: jaxws-wsse-sign-encrypt.jar) in 9ms
 [0m [0m05:59:46,748 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location /store/work/tc-work/29472398f1ae6497/full/testsuite/integration/ws/target/wildfly/standalone/data/content/10/914d86d54c88d0dafaf1d40bd93a7b041180e6/content
 [0m [0m05:59:46,748 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0009: Undeployed "jaxws-wsse-sign-encrypt.jar" (runtime-name: "jaxws-wsse-sign-encrypt.jar")
 [0m [0m05:59:46,765 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /store/work/tc-work/29472398f1ae6497/full/testsuite/integration/ws/target/wildfly/standalone/data/content/fb/a0b796363f5df3111da317117e382a153e3305/content
 [0m [0m05:59:46,766 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0027: Starting deployment of "jaxws-wsse-sign-encrypt-mc.war" (runtime-name: "jaxws-wsse-sign-encrypt-mc.war")
 [0m [33m05:59:46,816 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-6) WFLYSRV0018: Deployment "deployment.jaxws-wsse-sign-encrypt-mc.war" is using a private module ("org.wildfly.security.manager") which may be changed or removed in future versions without notice.
 [0m [0m05:59:46,845 INFO  [org.jboss.ws.cxf.metadata] (MSC service thread 1-3) JBWS024061: Adding service endpoint metadata: id=org.jboss.as.test.integration.ws.wsse.POJOEncryptServiceImpl
 address=http://[::1]:8080/jaxws-wsse-sign-encrypt-mc/EncryptSecurityService
 implementor=org.jboss.as.test.integration.ws.wsse.POJOEncryptServiceImpl
 serviceName={http://www.jboss.org/jbossws/ws-extensions/wssecuritypolicy}EncryptSecurityService
 portName={http://www.jboss.org/jbossws/ws-extensions/wssecuritypolicy}EncryptSecurityServicePort
 annotationWsdlLocation=WEB-INF/wsdl/SecurityService.wsdl
 wsdlLocationOverride=null


Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkalina Looks ok from a management point of view, but please get someone from the security team to approve as well.

@hkalina
Copy link
Author

hkalina commented Jan 26, 2018

@darranl can you approve this?

static class ScramDigest {
static final SimpleAttributeDefinition ALGORITHM = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.ALGORITHM, ModelType.STRING)
.setRequired(false)
.setDefaultValue(new ModelNode(ScramDigestPassword.ALGORITHM_SCRAM_SHA_1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to use a stronger hash function by default. It looks like SHA-512 is being used for the defaults for other password types.

@hkalina
Copy link
Author

hkalina commented Feb 9, 2018

@fjuma updated

@bstansberry bstansberry merged commit d012757 into wildfly:master Feb 10, 2018
@hkalina hkalina deleted the WFCORE-3541 branch February 10, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants