Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-3549] Downgrade jboss-logmanager to a final version, 2.0.9.Final #3069

Merged
merged 1 commit into from Jan 26, 2018

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Jan 25, 2018

https://issues.jboss.org/browse/WFCORE-3549

We should be keeping components as final. An alpha version of the log manager was added so the json-formatter could be added. However this should only be done once the log manager itself is final.

@jamezp
Copy link
Member Author

jamezp commented Jan 25, 2018

I'm not sure why the ModuleInfoTestCase keeps failing. It works for me locally and did pass a CI job where I ran the test by itself https://ci.wildfly.org/viewLog.html?buildId=86580&buildTypeId=WildFlyCore_MasterIgnoreLinux&tab=testsInfo.

@bstansberry
Copy link
Contributor

I don't know why TeamCity doesn't report the exception cause; the ModuleLoadException should have one.

From the first line in the stack trace I believe it's failing at ModuleXmlParser L976:

resourceLoader = MavenArtifactUtil.createMavenArtifactLoader(mavenResolver, name);

My guess is it's something funky in how the internal maven stuff in jboss-modules is resolving things. Obviously the artifact is available in the CI process or build would have failed.

@jamezp
Copy link
Member Author

jamezp commented Jan 25, 2018

Yeah that's what didn't make sense to me. If the artifact was missing all the tests should be failing. It really just doesn't make sense to me.

@jamezp
Copy link
Member Author

jamezp commented Jan 26, 2018

retest this please

@bstansberry
Copy link
Contributor

retest this please

I'm real tempted to merge this for today's core release if keeps on passing now. I fear the gods will punish me though.

@jamezp
Copy link
Member Author

jamezp commented Jan 26, 2018

I just reran the two failed jobs. Fingers crossed they will pass this time.

@bstansberry bstansberry merged commit caa8510 into wildfly:master Jan 26, 2018
@jamezp jamezp deleted the WFCORE-3549 branch February 15, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants