[WFCORE-3684] Upgrade to JBoss Modules 1.8.0.Final, including [WFCORE-3705] support for JDK modules

[stuartwdouglas]

https://issues.jboss.org/browse/WFCORE-3684
https://issues.jboss.org/browse/WFCORE-3705
https://issues.jboss.org/browse/WFCORE-3733
wildfly/wildfly-proposals#39

[wildfly-ci]

Core - Full Integration Build 7061 outcome was UNKNOWN using a merge of e056fc7
Summary: Canceled (Error while applying patch; cannot find commit 92dc20e in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3201/merge branch was updated and the commit selected for the ... Build time: 00:00:18

[wildfly-ci]

Core - Full Integration Build 7063 outcome was UNKNOWN using a merge of 686f9f6
Summary: Canceled (Error while applying patch; cannot find commit 5fd9dcc in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3201/merge branch was updated and the commit selected for the ... Build time: 00:00:12

[stuartwdouglas]

Retest this please

[wildfly-ci]

Core - Full Integration Build 7062 outcome was FAILURE using a merge of 686f9f6
Summary: Tests failed: 3 (3 new), passed: 4318, ignored: 138 Build time: 01:55:15

Failed tests

org.jboss.as.security.vault.VaultToolTestCase.testVaultFallback: java.lang.RuntimeException
	at org.jboss.as.server.services.security.RuntimeVaultReader.<init>(RuntimeVaultReader.java:61)
	at org.jboss.as.security.vault.MockRuntimeVaultReader.<init>(MockRuntimeVaultReader.java:18)
	at org.jboss.as.security.vault.VaultToolTestCase.doTestVaultTool(VaultToolTestCase.java:95)
	at org.jboss.as.security.vault.VaultToolTestCase.testVaultFallback(VaultToolTestCase.java:66)


org.jboss.as.security.vault.VaultToolTestCase.testVaultTool: java.lang.RuntimeException
	at org.jboss.as.server.services.security.RuntimeVaultReader.<init>(RuntimeVaultReader.java:61)
	at org.jboss.as.security.vault.MockRuntimeVaultReader.<init>(MockRuntimeVaultReader.java:18)
	at org.jboss.as.security.vault.VaultToolTestCase.doTestVaultTool(VaultToolTestCase.java:95)
	at org.jboss.as.security.vault.VaultToolTestCase.testVaultTool(VaultToolTestCase.java:61)


org.jboss.as.security.vault.VaultToolTestCase.testNoKeyStoreFile: java.lang.RuntimeException
	at org.jboss.as.server.services.security.RuntimeVaultReader.<init>(RuntimeVaultReader.java:61)
	at org.jboss.as.security.vault.MockRuntimeVaultReader.<init>(MockRuntimeVaultReader.java:18)
	at org.jboss.as.security.vault.VaultToolTestCase.doTestVaultTool(VaultToolTestCase.java:95)
	at org.jboss.as.security.vault.VaultToolTestCase.testNoKeyStoreFile(VaultToolTestCase.java:71)

[bstansberry]

The third commit looks fine.

@psakar FYI re the 2nd commit in case it affects you. (I just have a vague feeling of having seen something where it might so I wanted to point this out.)

@dmlloyd @n1hility re the first commit / WFCORE-3705 before deprecating widely used modules shouldn't we first eliminate all places where our code adds them as dependencies to apps? Causing apps to log deprecation warnings when the action to be taken is for us to fix our code isn't user friendly.

[psakar]

@stuartwdouglas How will be artifacts version determined ? I can not find any information on related JIRAs
@rsvoboda FYI

[stuartwdouglas]

@psakar that is a question for @dmlloyd, all I did was fix the ee8 preview stuff

[dmlloyd]

@bstansberry my plan was to follow up with dependency updates. I wanted to separate that because it should be clear that it isn't a requirement to make this work.

That said, I think deprecation warnings are unlikely because I believe all the currently impacted modules are implicit dependencies (I will double-check this though).

[dmlloyd]

Here's how the deprecations are mapped:

javax.sql.api -> java.sql
javax.api -> java.se (or better yet, break out the independent deps)
javax.xml.*.api -> java.xml

[bstansberry]

@dmlloyd Ah, ModuleLoadService doesn't log the WARN except for explicitly user-specified dependencies, so that addresses my concern. For explicitly user-specified ones, the WARN is of course the right thing to do.

Sorry for the noise.

[dmlloyd]

@psakar automatic version detection is covered in https://issues.jboss.org/browse/MODULES-343 .

[rsvoboda]

JBoss Modules 1.8 are feature/enhancement rich, maybe we should have some summary for this release and send it to the wildfly-dev list

https://issues.jboss.org/issues/?jql=project%20%3D%20MODULES%20AND%20fixVersion%20%3D%201.8.0.Final%20ORDER%20BY%20issuetype%20DESC

[dmlloyd]

Done: http://lists.jboss.org/pipermail/wildfly-dev/2018-April/006467.html