[WFCORE-3999] Allow registering a custom HTTP handler for management interface #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface * add addManagementHandler(String, boolean, HttpHandler) method to the ExtensibleHttpManagement API JIRA: https://issues.jboss.org/browse/WFCORE-3999
11 tasks
rsvoboda
reviewed
Aug 9, 2018
| String context = fixPath(contextName); | ||
| // Reject reserved contexts or duplicate extensions | ||
| if (extensionHandlers.reservedContexts.contains(context) || !extensionHandlers.extensionContexts.add(context)) { | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
error message could be handy
rsvoboda
approved these changes
Aug 9, 2018
| @@ -141,14 +142,27 @@ private void test(final ManagementClient managementClient) throws IOException { | |||
| final String staticUrlDirectory = urlBase + "static/"; | |||
| final String badStaticUrl = urlBase + "static/bad.txt"; | |||
| final String errorUrl = urlBase + "error/index.html"; | |||
| final String securedDynamicUrl = urlBase + "secured-dynamic/"; | |||
| final String unsecuredDynamicUrl = urlBase + "unsecured-dynamic/"; | |||
|
|
|||
There was a problem hiding this comment.
I tried without trailing / and tests are passing too. Probably not worth specific test as this use-case will be covered by /health endpoint in mp health work
bstansberry
approved these changes
Aug 9, 2018
jmesnil
added
ready-for-merge
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensibleHttpManagement API
JIRA: https://issues.jboss.org/browse/WFCORE-3999
Proposal: wildfly/wildfly-proposals#117