[WFCORE-4085] Temporarily use WF14 as the transformation target for EAP #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.2.0. Once EAP 7.2.0 is released there is a follow up task to switch it to use EAP 7.2.0 proper in WFCORE-4089
darranl
reviewed
Sep 6, 2018
|
|
||
| // TODO https://issues.jboss.org/browse/WFCORE-4089 Get rid of EAP_7_2_0_TEMP and enable EAP_7_2_0, once | ||
| // 7.2.0.GA-redhat-xx version is known | ||
| EAP_7_2_0_TEMP("11.0.0.Final", false, "14.0.0", "6.0.1.Final", "wf14"), |
There was a problem hiding this comment.
Wouldn't it be better to just call this 'EAP_7_2_0' - that way subsystems that reference it will not need to be updated when this gets renamed / a new one added.
There was a problem hiding this comment.
@darranl I prefer a replace, for the reasons given in https://issues.jboss.org/browse/WFCORE-4085
There was a problem hiding this comment.
Ok, I suppose the Strings in this enum will still be updatable so as we have later tags we can still have CI runs against those tags.
If we have any further non Final tags will probably still be worth updating the referenced models so we don't end up in a position where we tag WF 15 and find it is incompatible with a later EAP tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.2.0. Once EAP 7.2.0 is released there is a follow up task to switch it
to use EAP 7.2.0 proper in WFCORE-4089
https://issues.jboss.org/browse/WFCORE-4085