[WFCORE-4266] Support MR JAR resource loading from VFSResourceLoader #3636
Conversation
|
This class does not have unit tests. We might want to have a test plan for this class before merging. |
server/src/main/java/org/jboss/as/server/deployment/module/VFSResourceLoader.java
Outdated
Show resolved
Hide resolved
dmlloyd
force-pushed
the
wfcore-4266
branch
2 times, most recently
from
1d8e4da
to
f1ddea9
Compare
|
I've also pushed up an update where it will only seek out versioned entries if the |
|
Pushed up an NPE fix. https://github.com/wildfly/wildfly-core/compare/f1ddea9..1cfb7a0 |
This comment has been minimized.
This comment has been minimized.
|
I do believe that CI is lying about what version it ran with. |
|
Retest this please |
|
retest this please |
server/src/main/java/org/jboss/as/server/deployment/module/VFSResourceLoader.java
Show resolved
Hide resolved
server/src/main/java/org/jboss/as/server/deployment/module/VFSResourceLoader.java
Outdated
Show resolved
Hide resolved
jmesnil
added
the
ready-for-merge
| @@ -123,18 +141,41 @@ public Manifest run() throws IOException { | |||
| throw new UndeclaredThrowableException(e); | |||
| } | |||
| } | |||
| // "A multi-release jar file is a jar file that contains a manifest with a main attribute named "Multi-Release", [...]" | |||
| multiRelease = manifest != null && manifest.getMainAttributes().containsKey(MULTI_RELEASE_NAME); | |||
There was a problem hiding this comment.
Hi @dmlloyd, apparently the value of that attribute must be true for the multi-release jar to be considered enabled https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-January/058131.html
There was a problem hiding this comment.
Thanks for the note. Could you please open a JIRA (it can have "minor" priority)? And a PR if you want to. Thanks.
There was a problem hiding this comment.
https://issues.jboss.org/browse/WFCORE-4266