[WFCORE-4412] Eliminating CapabilityServiceTarget.addCapability() deprecated method usages

[ropalka]

https://issues.jboss.org/browse/WFCORE-4412

[darranl]

I think the Elytron refactoring needs removing from this PR - technically that commit should also have a Jira reference anyway but we have a separate PR being prepared that is looking to reduce the startup mode of a number of services #3729

[ropalka]

The commit was excluded as you suggested @darranl

Elytron commits removed.

[ropalka]

Retest this please

[wildfly-ci]

Core - Full Integration Build 8504 outcome was FAILURE using a merge of 75df45d
Summary: Tests failed: 1 (1 new), passed: 4851, ignored: 134 Build time: 02:03:36

Failed tests

org.jboss.as.test.integration.messaging.mgmt.JMSTopicManagementTestCase.testCountMessagesForSubscription: java.lang.AssertionError: expected:<2> but was:<0>
	at org.jboss.as.test.integration.messaging.mgmt.JMSTopicManagementTestCase.testCountMessagesForSubscription(JMSTopicManagementTestCase.java:231)

[ropalka]

Retest this please

[darranl]

@ropalka please don't use the test phrase unless you see a lot of errors as you kick off loads of jobs on CI that already passed. Instead click on the details link and you can click run at the top right of the results screen to kick off the specific job again.

[ropalka]

Thanks for the hint @darranl - will do it since now on.

[jmesnil]

Looks good to me (except my question about elytron's TrivialAddHandler)

[jmesnil]

@darranl @ropalka Is it ok to keep this elytron change or should it be handled by another Elytron PR?

[darranl]

@jmesnil this current change looks Ok to me, the issue was previously @ropalka was removing an 'unused' method that coincidentally a second PR was about to start using.