Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-4875] Provide common capability for Remoting connectors. #4099

Merged
merged 1 commit into from Mar 20, 2020
Merged

[WFCORE-4875] Provide common capability for Remoting connectors. #4099

merged 1 commit into from Mar 20, 2020

Conversation

rachmatowicz
Copy link
Contributor

This PR allows Remoting subsystem connector elements to be referenced by a common capability reference.

For details, see: https://issues.redhat.com/browse/WFCORE-4875

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Mar 17, 2020
pferraro
pferraro previously requested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to indicate that CONNECTOR_CAPABILITY allows multiple registrations via RuntimeCapability.Builder.setAllowMultipleRegistrations(true).

@rachmatowicz
Copy link
Contributor Author

Don't forget to indicate that CONNECTOR_CAPABILITY allows multiple registrations via RuntimeCapability.Builder.setAllowMultipleRegistrations(true).

Done.

@jmesnil jmesnil dismissed pferraro’s stale review March 20, 2020 09:48

Richard has update the PR according to your request

@jmesnil jmesnil merged commit 83fa553 into wildfly:master Mar 20, 2020
@jmesnil
Copy link
Member

jmesnil commented Mar 20, 2020

@rachmatowicz thanks

@rachmatowicz rachmatowicz mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pferraro pferraro pferraro left review comments

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
4 participants
@rachmatowicz @jmesnil @pferraro @wildfly-ci