Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4748] Allow the MODULE_OPTS to be set #4131

Merged
merged 1 commit into from Jun 22, 2020

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Apr 6, 2020

NOTE: This is not yet complete, but I wanted to get a CI run to test the different environments.

The first commit just upgrades the wildfly-maven-plugin and changes the property name is it was rather confusing with the version.org.wildfly.plugins property.

The second commit exposes the MODULE_OPTS environment variable and adds jboss-modules.jar as an agent if there is an agent defined in the options. A documentation PR will be required upstream before this can be merged.

https://issues.redhat.com/browse/WFCORE-4748
https://issues.redhat.com/browse/WFCORE-4897

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 6, 2020
@jamezp jamezp force-pushed the WFCORE-4748 branch 2 times, most recently from 35db97c to 624508e Compare April 14, 2020 22:31
@wildfly-ci
Copy link

Core - Full Integration Build 9528 outcome was UNKNOWN using a merge of 35db97c
Summary: Canceled (Tests passed: 4619, ignored: 69; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 01:08:55

@jmesnil jmesnil added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Apr 22, 2020
@jamezp jamezp marked this pull request as ready for review May 8, 2020 22:49
@jamezp jamezp force-pushed the WFCORE-4748 branch 4 times, most recently from def6202 to 4a33051 Compare May 15, 2020 14:48
@jamezp
Copy link
Member Author

jamezp commented May 15, 2020

@wildfly/mergers-core Just an FYI the last change which triggers the rebuild will have no affect on testing and this was previously green. The only two changes were a change to the attribute description and a change to the DomainCommandBuilder.

@jamezp jamezp removed the missing-reqs This PR is missing external requirements before it can be merged label May 15, 2020
@wildfly-ci
Copy link

Core - Full Integration Build 9658 outcome was FAILURE using a merge of 4a33051
Summary: Execution timeout (new); tests failed: 1408 (1408 new), passed: 1349, ignored: 1360, muted: 2 Build time: 05:01:06

Failed tests

org.jboss.as.test.integration.jpa.dsrestart.JpaDsRestartTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.jca.security.workmanager.WildFlyActivationRaWithWMElytronSecurityDomainWorkManagerElytronDisabledTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.eclipse.microprofile.metrics.tck.tags.GlobalTagsTest: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.weld.modules.export.ExportedModuleTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.deployment.classloading.ear.EarJbossStructureRestrictedVisibilityTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.jaxrs.jackson.JaxrsJacksonProviderTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.ejb.java8.Java8InterfacesEJBTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.ee.injection.resource.basic.ResourceInjectionTestCase: 	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more
------- Stdout: -------
07:49:07,327 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final
07:49:07,572 INFO  [org.jboss.as.arquillian.container.managed.ManagedDeployableContainer] (main) Starting container with: [/usr/java/jdk1.8.0_152/bin/java, -D[Standalone], -Dorg.jboss.ejb.client.wildfly-testsuite-hack=true, -Xmx512m, -XX:MetaspaceSize=128m, -Djboss.dist=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/../../../build/target/wildfly-20.0.0.Beta1-SNAPSHOT, -Dmaven.repo.local=/store/repository, -Djava.net.preferIPv4Stack=false, -Djava.net.preferIPv6Addresses=true, -Djboss.bind.address=::1, -Djboss.bind.address.unsecure=::1, -Djboss.bind.address.private=::1, -Djboss.bind.address.management=::1, -Djboss.default.multicast.address=ff13::1, -server, -Dts.timeout.factor=100, -Dnode0=::1, -Dnode1=::1, -Dmcast=ff13::1, -Dmcast.ttl=0, -Djbossas.ts.submodule.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic, -Djbossas.ts.integ.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/.., -Djbossas.ts.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/../.., -Djbossas.project.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/../../.., -Djava.io.tmpdir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target, -ea, -Djboss.home.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly, -Djboss.home.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly, -Djboss.server.base.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/standalone, -Djboss.server.log.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/standalone/log, -Djboss.server.config.dir=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/standalone/configuration, -Dorg.jboss.boot.log.file=/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/standalone/log/server.log, -Dlogging.configuration=file:/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/standalone/configuration/logging.properties, -jar, /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/jboss-modules.jar, -mp, /store/work/tc-work/37b47ae8b9c60325/full/build/target/wildfly-20.0.0.Beta1-SNAPSHOT/modules:/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/modules, org.jboss.as.standalone, -Dts.wildfly.version=20.0.0.Beta1-SNAPSHOT, -c=standalone-full.xml]
07:49:07,667 INFO  [org.jboss.remoting] (main) JBoss Remoting version 5.0.18.Final
07:49:07,735 INFO  [org.xnio] (main) XNIO version 3.8.0.Final
07:49:07,778 INFO  [org.xnio.nio] (main) XNIO NIO Implementation Version 3.8.0.Final
07:49:07,916 INFO  [org.wildfly.security] (main) ELY00001: WildFly Elytron version 1.12.0.CR1
07:49:08,024 INFO  [org.jboss.ejb.client] (main) EJBCLIENT000069: Using legacy jboss-ejb-client.properties security configuration
 [0m07:49:08,730 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.1.Final
 [0m [0m07:49:09,371 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
 [0m [0m07:49:09,385 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final
 [0m [0m07:49:09,599 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: WildFly Full 20.0.0.Beta1-SNAPSHOT (WildFly Core 12.0.0.Beta3-SNAPSHOT) starting
 [0m [0m07:49:11,678 INFO  [org.wildfly.security] (ServerService Thread Pool -- 17) ELY00001: WildFly Elytron version 1.12.0.CR1
 [0m [0m07:49:13,150 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m07:49:13,199 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 9) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m07:49:13,370 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m07:49:13,399 INFO  [org.xnio] (MSC service thread 1-1) XNIO version 3.8.0.Final
 [0m [0m07:49:13,410 INFO  [org.xnio.nio] (MSC service thread 1-1) XNIO NIO Implementation Version 3.8.0.Final
 [0m [0m07:49:13,506 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 56) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m07:49:13,559 INFO  [org.wildfly.extension.microprofile.config.smallrye._private] (ServerService Thread Pool -- 67) WFLYCONF0001: Activating WildFly MicroProfile Config Subsystem
 [0m [0m07:49:13,562 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 58) WFLYRS0016: RESTEasy version 3.11.2.Final
 [0m [0m07:49:13,578 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 72) WFLYNAM0001: Activating Naming Subsystem
 [0m [0m07:49:13,598 INFO  [org.wildfly.extension.microprofile.jwt.smallrye._private] (ServerService Thread Pool -- 69) WFLYJWT0001: Activating WildFly MicroProfile JWT Subsystem
 [0m [33m07:49:13,606 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 80) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m07:49:13,646 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 82) WFLYWS0002: Activating WebServices Extension
 [0m [0m07:49:13,659 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 57) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m07:49:13,665 INFO  [org.wildfly.iiop.openjdk] (ServerService Thread Pool -- 55) WFLYIIOP0001: Activating IIOP Subsystem
 [0m [0m07:49:13,677 INFO  [org.jboss.as.security] (ServerService Thread Pool -- 78) WFLYSEC0002: Activating Security Subsystem
 [0m [0m07:49:13,688 INFO  [org.wildfly.extension.microprofile.opentracing] (ServerService Thread Pool -- 71) WFLYTRACEXT0001: Activating MicroProfile OpenTracing Subsystem
 [0m [0m07:49:13,696 INFO  [org.jboss.as.jsf] (ServerService Thread Pool -- 63) WFLYJSF0007: Activated the following JSF Implementations: [main]
 [0m [0m07:49:13,719 INFO  [org.jboss.as.naming] (MSC service thread 1-5) WFLYNAM0003: Starting Naming Service
 [0m [0m07:49:13,744 INFO  [org.jboss.as.connector] (MSC service thread 1-6) WFLYJCA0009: Starting JCA Subsystem (WildFly/IronJacamar 1.4.22.Final)
 [0m [0m07:49:13,764 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-3) WFLYMAIL0001: Bound mail session [java:jboss/mail/Default]
 [0m [0m07:49:13,798 INFO  [org.wildfly.extension.microprofile.health.smallrye] (ServerService Thread Pool -- 68) WFLYHEALTH0001: Activating Eclipse MicroProfile Health Subsystem
 [0m [0m07:49:13,824 INFO  [org.jboss.as.security] (MSC service thread 1-1) WFLYSEC0001: Current PicketBox version=5.0.3.Final-redhat-00005
 [0m [0m07:49:13,860 INFO  [org.jboss.remoting] (MSC service thread 1-7) JBoss Remoting version 5.0.18.Final
 [0m [0m07:49:13,873 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0003: Undertow 2.1.0.Final starting
 [0m [0m07:49:13,954 INFO  [org.wildfly.extension.microprofile.metrics.smallrye] (ServerService Thread Pool -- 70) WFLYMETRICS0001: Activating Eclipse MicroProfile Metrics Subsystem
 [0m [0m07:49:14,095 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 47) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [0m07:49:14,415 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-2) WFLYJCA0018: Started Driver service with driver-name = h2
 [0m [0m07:49:14,404 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 81) WFLYUT0014: Creating file handler for path '/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/basic/target/wildfly/welcome-content' with options [directory-listing: 'false', follow-symlink: 'false', case-sensitive: 'true', safe-symlink-paths: '[]']
 [0m [0m07:49:14,595 INFO  [org.jboss.as.ejb3] (MSC service thread 1-5) WFLYEJB0481: Strict pool slsb-strict-max-pool is using a max instance size of 64 (per class), which is derived from thread worker pool sizing.
 [0m [0m07:49:14,607 INFO  [org.jboss.as.ejb3] (MSC service thread 1-8) WFLYEJB0482: Strict pool mdb-strict-max-pool is using a max instance size of 16 (per class), which is derived from the number of CPUs on this host.
 [0m [0m07:49:14,715 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0012: Started server default-server.
 [0m [0m07:49:14,737 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0018: Host default-host starting
 [0m [0m07:49:15,100 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0006: Undertow HTTP listener default listening on [::1]:8080


org.jboss.as.test.integration.transaction.MaximumTimeoutTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.ejb.descriptor.ejbnamewildcard.EJBNameWildcardTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more


org.jboss.as.test.integration.deployment.resourcelisting.EarResourceListingTestCase: java.lang.RuntimeException: Arquillian initialization has already been attempted, but failed. See previous exceptions for cause
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:168)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	... 10 more
Caused by: java.util.concurrent.TimeoutException: Managed server was not started within [60] s
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:161)
	... 66 more



##### there are 1398 more failed tests, see build details

@jamezp
Copy link
Member Author

jamezp commented Jun 18, 2020

This has been rebased and updated for WildFly Core 13.

@jmesnil
Copy link
Member

jmesnil commented Jun 19, 2020

@jamezp sorry (again!), this PR also needs a rebase after #4234. The impacted files are now in https://github.com/wildfly/wildfly-core/tree/master/core-feature-pack/common/src/main/resources/content/bin

@jmesnil jmesnil added the rebase-this This PR must be rebased before it is merged label Jun 19, 2020
…s found in the options automatically add jboss-modules as an agent to the VM.

https://issues.redhat.com/browse/WFCORE-4748
@jamezp jamezp removed the rebase-this This PR must be rebased before it is merged label Jun 19, 2020
@jamezp
Copy link
Member Author

jamezp commented Jun 19, 2020

Not a problem at all @jmesnil. I've rebased it and removed the label.

@jmesnil jmesnil merged commit 17c383f into wildfly:master Jun 22, 2020
@jmesnil
Copy link
Member

jmesnil commented Jun 22, 2020

@jamezp thanks

@jamezp jamezp deleted the WFCORE-4748 branch June 22, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature This PR adds a new feature to WildFly
Projects
None yet
4 participants