New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-4748] Allow the MODULE_OPTS to be set #4131
Conversation
35db97c
to
624508e
Compare
Core - Full Integration Build 9528 outcome was UNKNOWN using a merge of 35db97c |
core-feature-pack/src/main/resources/content/bin/standalone.conf.bat
Outdated
Show resolved
Hide resolved
def6202
to
4a33051
Compare
@wildfly/mergers-core Just an FYI the last change which triggers the rebuild will have no affect on testing and this was previously green. The only two changes were a change to the attribute description and a change to the |
Core - Full Integration Build 9658 outcome was FAILURE using a merge of 4a33051 Failed tests
|
6253c8e
to
5bd14ad
Compare
This has been rebased and updated for WildFly Core 13. |
@jamezp sorry (again!), this PR also needs a rebase after #4234. The impacted files are now in https://github.com/wildfly/wildfly-core/tree/master/core-feature-pack/common/src/main/resources/content/bin |
…s found in the options automatically add jboss-modules as an agent to the VM. https://issues.redhat.com/browse/WFCORE-4748
Not a problem at all @jmesnil. I've rebased it and removed the label. |
@jamezp thanks |
NOTE: This is not yet complete, but I wanted to get a CI run to test the different environments.
The first commit just upgrades the wildfly-maven-plugin and changes the property name is it was rather confusing with the
version.org.wildfly.plugins
property.The second commit exposes the
MODULE_OPTS
environment variable and addsjboss-modules.jar
as an agent if there is an agent defined in the options. A documentation PR will be required upstream before this can be merged.https://issues.redhat.com/browse/WFCORE-4748
https://issues.redhat.com/browse/WFCORE-4897