[WFCORE-944] truststore path is ignored if provider is not JKS #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
|
It may be in the existing code, I can't quite see how the test activates a trust store with a different type? |
darranl
approved these changes
Jun 23, 2020
darranl
added
the
ready-for-merge
|
@rmartinc thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-944
I just used @darranl 's fix (#3841) but a manual test that used PKCS12 was modified to include this use-case. Indeed the test is better now. Previously the provider was not specified in the configuration (server-identity/ssl or authentication/truststore) and that seems to work in openjdk but fails in other implementations (IBM for example). So we are killing two birds with one stone.