New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-5079] Remove temporary "secure-managament" alias. #4296
Conversation
management - secured by WildFly Elytron legacy-management - secured by legacy security realms core-tools and jmx-remoting optionally depend on management but this layer can be excluded to depend on legacy-security instead.
…ould instead come in via the management layers.
…agement" until WildFly has switched to use "management".
…for "management" until WildFly has switched to use "management"." This reverts commit 9149261.
Core - Full Integration Build 9849 outcome was FAILURE using a merge of af51949 |
Core - Full Integration Build 9890 outcome was FAILURE using a merge of af51949 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are layers on S2I that are using the management layer directly, which now will be a secured layer. There are other layers that redefine it. I haven't found any uses of jmx-remoting or secure-management.
@darranl Do you think we can finally merge this one? there is no |
/retest |
@yersan Just removed the hold label - the PR to WildFly is now merged so just kicked off a test run to see if this is clean now. |
@yersan if I can get a clean CI run I will bundle this up with other changes coming to core to get it merged. |
Core - Full Integration Build 9918 outcome was FAILURE using a merge of af51949 Failed tests
|
Core - Full Integration Build 9968 outcome was FAILURE using a merge of af51949 Failed tests
|
https://issues.redhat.com/browse/WFCORE-5079
This pull request follows up on #4295 to remove the temporary "secure-management" alias.
This PR can only be merged after wildfly/wildfly#13468 as WildFly has a dependency on the "secure-management" layer. An immediate tag of core is not required after merging this one.