[WFCORE-5087] Add support for the -secmgr command line argument, #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of -Djava.security.manager. This follows the same pattern as used by JBoss Modules to initialise the supported SecurityManager during bootstrap.
wildfly-ci
added
the
deps-ok
jamezp
approved these changes
Aug 12, 2020
jamezp
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is borrowed from JBoss Modules which follows a similar pattern of being started from a "java -jar" command before performing the rest of the bootstrap process.
https://issues.redhat.com/browse/WFCORE-5087
Unlike JBoss Modules this does not support alternative security managers as we only support WildFlySecurityManager with the running server.
The following example update makes use of the new -secmgr command line argument:
wildfly-extras/wildfly-jar-maven-plugin#46