Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-5103] Adding non existent and not required keystore fails #4323

Merged
merged 1 commit into from Sep 15, 2020
Merged

[WFCORE-5103] Adding non existent and not required keystore fails #4323

merged 1 commit into from Sep 15, 2020

Conversation

nekdozjam
Copy link
Contributor

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Sep 8, 2020
fjuma
fjuma approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nekdozjam.

@darranl
Copy link
Contributor

darranl commented Sep 11, 2020

@nekdozjam I am not sure of the reported error could be related, I am going to trigger CI once more for Windows but some of these domain tests to test permutations of configuration options so it is possible they test the permutation you now reject.

https://ci.wildfly.org/viewLog.html?buildId=220997&buildTypeId=WildFlyCore_PullRequest_WildFlyCoreFullIntegrationWindows

@darranl darranl added the 13.x label Sep 14, 2020
@darranl
Copy link
Contributor

darranl commented Sep 14, 2020

Different failure this time, going to bundle up to get through,

@darranl darranl mentioned this pull request Sep 14, 2020
Closed
@darranl darranl merged commit 99eb7fa into wildfly:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
4 participants
@nekdozjam @darranl @fjuma @wildfly-ci