-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-13828 remote+tls is not supported by EJBClient and remote-outbou… #4349
Conversation
Core - Full Integration Build 10031 outcome was FAILURE using a merge of d1b4c6f Failed tests
|
Core - Full Integration Build 10037 outcome was FAILURE using a merge of d1b4c6f Failed tests
|
@ropalka could you please review? In particular would that need a release of jboss-ejb-client with wildfly/jboss-ejb-client#475 merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say also the following files should be updated accordingly @RanabirChakraborty :
- cli/src/main/java/org/jboss/as/cli/ControllerAddressResolver.java
- protocol/src/main/java/org/jboss/as/protocol/ProtocolConnectionConfiguration.java
I would say this is another feature available via future jboss-ejb-client upgrade @jmesnil . |
@ropalka thanks, I've requalified WFLY-13828 as a Feature Request that will have to follow our regular process for new features. |
There has been no activity on this PR for 30 days. It will be auto-closed after 90 days. |
This will require a bump in the mgmt api version in RemotingExtension and an update to RemotingTransformers a la what's in L111. This is a pre-existing problem but the ConnectorCommon.SASL_PROTOCOL attribute def at a glance looks like it should be limited to values in the Protocol enum. That should be investigated (carefully -- the fact its in a ''common" class hints it's use is not simple/obvious) and if it's wrong, fixed as part of this work. That would likely involve some further changes to RemotingTransformers. |
There has been no activity on this PR for 30 days. It will be auto-closed after 90 days. |
@RanabirChakraborty / @ropalka Do we have a plan yet as to how this will be proceeding? At the moment it is flagged as an RFE which is not ready for merge but it appears the current outstanding steps are with the engineers to kick off the process. |
Issue: https://issues.redhat.com/browse/WFLY-13828
Other related PR for the same issue: #475