Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for WFCORE-5199, CLI, shaded jar can't start embedded when logging json formater configured #4448

Merged
merged 1 commit into from Jan 11, 2021
Merged

Fix for WFCORE-5199, CLI, shaded jar can't start embedded when logging json formater configured #4448

merged 1 commit into from Jan 11, 2021

Conversation

jfdenise
Copy link
Contributor

@jfdenise jfdenise commented Jan 7, 2021

Issue: https://issues.redhat.com/browse/WFCORE-5199
Did manual testing with bootable JAR, cli fat jar (with both jakarta8 and jakarata9).

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Dependency Tree Analyzer Output:

New Dependencies:

  • io.quarkus:quarkus-reactive-datasource:jar:1.5.0.Final:compile

CC @wildfly/prod

@jmesnil
Copy link
Member

jmesnil commented Jan 11, 2021

PR looks fine and the quarkus-reactive-datasource dependency looks suspicious to me.
CI failures are also unrelated to the PR.
I'll merge as it is

@jmesnil jmesnil merged commit 1febe54 into wildfly:master Jan 11, 2021
@jmesnil
Copy link
Member

jmesnil commented Jan 11, 2021

@jfdenise thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmesnil jmesnil jmesnil approved these changes

Assignees
No one assigned
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment
Projects
None yet
Milestone
No milestone
2 participants
@jfdenise @jmesnil